Bug 189935 - Bring up queues for Mojave
Summary: Bring up queues for Mojave
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryan Haddad
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-24 16:33 PDT by Ryan Haddad
Modified: 2018-09-27 18:26 PDT (History)
7 users (show)

See Also:


Attachments
Patch (16.85 KB, patch)
2018-09-24 16:39 PDT, Ryan Haddad
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2018-09-24 16:33:16 PDT
Bring up queues for Mojave
Comment 1 Ryan Haddad 2018-09-24 16:39:37 PDT
Created attachment 350711 [details]
Patch
Comment 2 Ryan Haddad 2018-09-24 16:40:32 PDT
This is good to review, but I need to hold on to the patch until I finish configuring hardware.
Comment 3 Ryan Haddad 2018-09-24 16:41:22 PDT
<rdar://problem/44111214>
Comment 4 Alexey Proskuryakov 2018-09-24 16:58:48 PDT
Comment on attachment 350711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350711&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:448
> +                    { "type": "Triggerable", "name": "mojave-leaks",
> +                      "builderNames": ["Apple Mojave (Leaks)"]
> +                    },

I think that High Sierra Leaks scheduler should be removed, as the bot moves.
Comment 5 Ryan Haddad 2018-09-24 17:08:17 PDT
(In reply to Alexey Proskuryakov from comment #4)
> Comment on attachment 350711 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=350711&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:448
> > +                    { "type": "Triggerable", "name": "mojave-leaks",
> > +                      "builderNames": ["Apple Mojave (Leaks)"]
> > +                    },
> 
> I think that High Sierra Leaks scheduler should be removed, as the bot moves.
Indeed it should. Thank you.
Comment 6 Ryan Haddad 2018-09-27 18:26:05 PDT
Landed in https://trac.webkit.org/r236580