WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
189928
Include more headers in IOSurface.mm, PixelBufferResizer.{h, mm}
https://bugs.webkit.org/show_bug.cgi?id=189928
Summary
Include more headers in IOSurface.mm, PixelBufferResizer.{h, mm}
Daniel Bates
Reported
2018-09-24 14:09:35 PDT
When shuffling around some files I caused my Mac build to fail to build IOSurface.mm and PixelBufferResizer.mm because of some missing #includes. This issue will only manifest itself if IOSurface.mm or PixelBufferResizer.mm are not unified with other translation units that have the missing #includes that they need. We should make building IOSurface.mm and PixelBufferResizer.mm deterministic and have them include the appropriate headers.
Attachments
Patch
(3.22 KB, patch)
2018-09-24 14:14 PDT
,
Daniel Bates
aestes
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2018-09-24 14:14:13 PDT
Created
attachment 350682
[details]
Patch
Daniel Bates
Comment 2
2018-09-24 15:47:43 PDT
Committed
r236432
: <
https://trac.webkit.org/changeset/236432
>
Radar WebKit Bug Importer
Comment 3
2018-09-24 15:48:35 PDT
<
rdar://problem/44743458
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug