Bug 189928 - Include more headers in IOSurface.mm, PixelBufferResizer.{h, mm}
Summary: Include more headers in IOSurface.mm, PixelBufferResizer.{h, mm}
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-24 14:09 PDT by Daniel Bates
Modified: 2018-09-24 15:48 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.22 KB, patch)
2018-09-24 14:14 PDT, Daniel Bates 		aestes: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-09-24 14:09:35 PDT 
When shuffling around some files I caused my Mac build to fail to build IOSurface.mm and PixelBufferResizer.mm because of some missing #includes. This issue will only manifest itself if IOSurface.mm or PixelBufferResizer.mm are not unified with other translation units that have the missing #includes that they need. We should make building IOSurface.mm and PixelBufferResizer.mm deterministic and have them include the appropriate headers.
Comment 1 Daniel Bates 2018-09-24 14:14:13 PDT 
Created attachment 350682 [details]
Patch
Comment 2 Daniel Bates 2018-09-24 15:47:43 PDT 
Committed r236432: <https://trac.webkit.org/changeset/236432>
Comment 3 Radar WebKit Bug Importer 2018-09-24 15:48:35 PDT 
<rdar://problem/44743458>