Bug 189909 - Remove duplicate CSS Properties and Values feature on status page
Summary: Remove duplicate CSS Properties and Values feature on status page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Trivial
Assignee: Justin Michaud
URL:
Keywords: FromImplementor, InRadar
Depends on:
Blocks: 189692
  Show dependency treegraph
 
Reported: 2018-09-23 23:37 PDT by Anders Ruud
Modified: 2018-09-27 15:30 PDT (History)
8 users (show)

See Also:


Attachments
Patch (2.03 KB, patch)
2018-09-27 14:29 PDT, Justin Michaud
no flags Details | Formatted Diff | Diff
Patch (2.40 KB, patch)
2018-09-27 14:38 PDT, Justin Michaud
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Ruud 2018-09-23 23:37:55 PDT
How great that you are implementing this spec! :)

If [1] could be updated with status "In Development", and [2] could be deleted, that would be great. It already caused some minor confusion.

[1] https://webkit.org/status/#specification-css-properties-and-values-api-level-1
[2] https://webkit.org/status/#specification-css-custom-properties-and-values
Comment 1 Justin Michaud 2018-09-27 14:29:48 PDT
Created attachment 351003 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-09-27 14:33:55 PDT
Comment on attachment 351003 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351003&action=review

> Source/WebCore/features.json:137
>          "keywords": ["css", "houdini"],

Would be nice to have description and webkit-url here and the better keywords.
Comment 3 Justin Michaud 2018-09-27 14:38:43 PDT
Created attachment 351004 [details]
Patch
Comment 4 EWS Watchlist 2018-09-27 14:50:12 PDT
Attachment 351004 [details] did not pass style-queue:


ERROR: Source/WebCore/features.json:0:  The feature "Pointer Events" has a specification field but no specification of that name exists.  [json/syntax] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Justin Michaud 2018-09-27 14:57:43 PDT
I think the style error is a false positive. I didn't change Pointer Events, and the spec does exist
Comment 6 WebKit Commit Bot 2018-09-27 15:29:34 PDT
Comment on attachment 351004 [details]
Patch

Clearing flags on attachment: 351004

Committed r236575: <https://trac.webkit.org/changeset/236575>
Comment 7 WebKit Commit Bot 2018-09-27 15:29:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-09-27 15:30:31 PDT
<rdar://problem/44846052>