WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
189909
Remove duplicate CSS Properties and Values feature on status page
https://bugs.webkit.org/show_bug.cgi?id=189909
Summary
Remove duplicate CSS Properties and Values feature on status page
Anders Ruud
Reported
2018-09-23 23:37:55 PDT
How great that you are implementing this spec! :) If [1] could be updated with status "In Development", and [2] could be deleted, that would be great. It already caused some minor confusion. [1]
https://webkit.org/status/#specification-css-properties-and-values-api-level-1
[2]
https://webkit.org/status/#specification-css-custom-properties-and-values
Attachments
Patch
(2.03 KB, patch)
2018-09-27 14:29 PDT
,
Justin Michaud
no flags
Details
Formatted Diff
Diff
Patch
(2.40 KB, patch)
2018-09-27 14:38 PDT
,
Justin Michaud
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Justin Michaud
Comment 1
2018-09-27 14:29:48 PDT
Created
attachment 351003
[details]
Patch
Simon Fraser (smfr)
Comment 2
2018-09-27 14:33:55 PDT
Comment on
attachment 351003
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=351003&action=review
> Source/WebCore/features.json:137 > "keywords": ["css", "houdini"],
Would be nice to have description and webkit-url here and the better keywords.
Justin Michaud
Comment 3
2018-09-27 14:38:43 PDT
Created
attachment 351004
[details]
Patch
EWS Watchlist
Comment 4
2018-09-27 14:50:12 PDT
Attachment 351004
[details]
did not pass style-queue: ERROR: Source/WebCore/features.json:0: The feature "Pointer Events" has a specification field but no specification of that name exists. [json/syntax] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Justin Michaud
Comment 5
2018-09-27 14:57:43 PDT
I think the style error is a false positive. I didn't change Pointer Events, and the spec does exist
WebKit Commit Bot
Comment 6
2018-09-27 15:29:34 PDT
Comment on
attachment 351004
[details]
Patch Clearing flags on attachment: 351004 Committed
r236575
: <
https://trac.webkit.org/changeset/236575
>
WebKit Commit Bot
Comment 7
2018-09-27 15:29:35 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8
2018-09-27 15:30:31 PDT
<
rdar://problem/44846052
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug