Bug 189903 – Import WPT resource-timing tests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yoav Weiss]

Import WPT resource-timing tests

[Yoav Weiss]

Created attachment 350596 [details]
Patch

[EWS Watchlist]

Comment on attachment 350596 [details]
Patch

Attachment 350596 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9325284

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 350597 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 350596 [details]
Patch

Attachment 350596 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9325302

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 350598 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 350596 [details]
Patch

Attachment 350596 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9325301

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 350600 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Yoav Weiss]

Created attachment 350602 [details]
Patch

[EWS Watchlist]

Comment on attachment 350602 [details]
Patch

Attachment 350602 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9326203

New failing tests:
imported/w3c/web-platform-tests/resource-timing/resource_timing.worker.html

[EWS Watchlist]

Created attachment 350604 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Yoav Weiss]

Created attachment 350606 [details]
Patch

[EWS Watchlist]

Comment on attachment 350606 [details]
Patch

Attachment 350606 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9326932

New failing tests:
imported/w3c/web-platform-tests/resource-timing/resource_timing_store_and_clear_during_callback.html

[EWS Watchlist]

Created attachment 350611 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Yoav Weiss]

Created attachment 350613 [details]
Patch

[Yoav Weiss]

Created attachment 350614 [details]
Patch

[Yoav Weiss]

Comment on attachment 350614 [details]
Patch

Thanks for reviewing! :)

[WebKit Commit Bot]

Comment on attachment 350614 [details]
Patch

Clearing flags on attachment: 350614

Committed r236402: <https://trac.webkit.org/changeset/236402>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44727969>

[Dawei Fenton (:realdawei)]

(In reply to WebKit Commit Bot from comment #17)
> Comment on attachment 350614 [details]
> Patch
> 
> Clearing flags on attachment: 350614
> 
> Committed r236402: <https://trac.webkit.org/changeset/236402>

The following test has been failing on mac WK1 since it was added:

imported/w3c/web-platform-tests/resource-timing/resource_timing.worker.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fresource-timing%2Fresource_timing.worker.html

[Dawei Fenton (:realdawei)]

(In reply to Dawei Fenton (:realdawei) from comment #20)
> (In reply to WebKit Commit Bot from comment #17)
> > Comment on attachment 350614 [details]
> > Patch
> > 
> > Clearing flags on attachment: 350614
> > 
> > Committed r236402: <https://trac.webkit.org/changeset/236402>
> 
> The following test has been failing on mac WK1 since it was added:
> 
> imported/w3c/web-platform-tests/resource-timing/resource_timing.worker.html
> 
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fresource-
> timing%2Fresource_timing.worker.html

Sample diff:
--- /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/imported/w3c/web-platform-tests/resource-timing/resource_timing.worker-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/imported/w3c/web-platform-tests/resource-timing/resource_timing.worker-actual.txt
@@ -1,3 +1,5 @@
 
-PASS Performance Resouce Entries in workers 
+Harness Error (TIMEOUT), message = null
 
+TIMEOUT Performance Resouce Entries in workers Test timed out
+

[Yoav Weiss]

Yeah, I've added that test to LayoutTests/platform/mac/TestExpectations and opened webkit.org/b/189908 on it.

Is that not enough to exclude it from mac WK1 test bots?

[Ryan Haddad]

(In reply to Yoav Weiss from comment #22)
> Yeah, I've added that test to LayoutTests/platform/mac/TestExpectations and
> opened webkit.org/b/189908 on it.
> 
> Is that not enough to exclude it from mac WK1 test bots?
It looks like the issue is that the test is hitting a timeout in the WPT harness, so it ends up being reported as a text failure rather than a timeout.

I'll update the expectations.