Patch from bug 188043 exhibits a possible build error when with unifiedbuild source rotating: In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource357.cpp:1: ./platform/text/TextCodecReplacement.cpp:49:30: error: implicit instantiation of undefined template 'WTF::Function<std::__1::unique_ptr<WebCore::TextCodec, std::__1::default_delete<WebCore::TextCodec> > ()>' registrar("replacement", [] { ^ In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource357.cpp:1: In file included from ./platform/text/TextCodecReplacement.cpp:27: In file included from ./platform/text/TextCodecReplacement.h:28: In file included from ./platform/text/TextCodecUTF8.h:28: In file included from ./platform/text/TextCodec.h:33: /Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/wtf/Forward.h:53:26: note: template is declared here template<typename> class Function; ^ In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource357.cpp:1: ./platform/text/TextCodecReplacement.cpp:49:30: note: candidate function registrar("replacement", [] { ^ ./platform/text/TextCodecReplacement.cpp:54:30: error: incomplete result type 'WTF::String' in function definition String TextCodecReplacement::decode(const char*, size_t, bool, bool, bool& sawError) ^ In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource357.cpp:1: In file included from ./platform/text/TextCodecReplacement.cpp:27: In file included from ./platform/text/TextCodecReplacement.h:28: In file included from ./platform/text/TextCodecUTF8.h:28: In file included from ./platform/text/TextCodec.h:33: /Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/wtf/Forward.h:39:7: note: forward declaration of 'WTF::String' class String; ^ In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource357.cpp:1: ./platform/text/TextCodecReplacement.cpp:58:16: error: use of undeclared identifier 'emptyString' return emptyString(); ^ ./platform/text/TextCodecReplacement.cpp:60:12: error: invalid use of incomplete type 'WTF::String' return String { &replacementCharacter, 1 }; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource357.cpp:1: In file included from ./platform/text/TextCodecReplacement.cpp:27: In file included from ./platform/text/TextCodecReplacement.h:28: In file included from ./platform/text/TextCodecUTF8.h:28: In file included from ./platform/text/TextCodec.h:33: /Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/wtf/Forward.h:39:7: note: forward declaration of 'WTF::String' class String; ^ 4 errors generated.
Created attachment 350570 [details] Patch
Comment on attachment 350570 [details] Patch Clearing flags on attachment: 350570 Committed r236393: <https://trac.webkit.org/changeset/236393>
All reviewed patches have been landed. Closing bug.
<rdar://problem/44715585>