Bug 189890 – [ARM] Building FELightingNEON.cpp fails due to missing lightVector member

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Adrian Perez]

SSIA. Compiler output (GCC 7) follows.

---

[ 53%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource319.cpp.o                                                 
In file included from /home/aperez/buildroot/output-wkgtk-rpi/build/webkitgtk-2.22.2/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.cpp:28:0,                       
                 from /home/aperez/buildroot/output-wkgtk-rpi/build/webkitgtk-2.22.2/DerivedSources/WebCore/unified-sources/UnifiedSource319.cpp:5:                                  
/home/aperez/buildroot/output-wkgtk-rpi/build/webkitgtk-2.22.2/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h: In member function ‘void WebCore::FELighting::platformApplyNeon(const WebCore::FELighting::LightingData&, const WebCore::LightSource::PaintingData&)’:                                                                                   
/home/aperez/buildroot/output-wkgtk-rpi/build/webkitgtk-2.22.2/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h:147:46: error: ‘const struct WebCore::LightSource::PaintingData’ has no member named ‘lightVector’; did you mean ‘directionVector’?
         floatArguments.lightX = paintingData.lightVector.x();
                                              ^~~~~~~~~~~
                                              directionVector
/home/aperez/buildroot/output-wkgtk-rpi/build/webkitgtk-2.22.2/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h:148:46: error: ‘const struct WebCore::LightSource::PaintingData’ has no member named ‘lightVector’; did you mean ‘directionVector’?
         floatArguments.lightY = paintingData.lightVector.y();
                                              ^~~~~~~~~~~
                                              directionVector
/home/aperez/buildroot/output-wkgtk-rpi/build/webkitgtk-2.22.2/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h:149:46: error: ‘const struct WebCore::LightSource::PaintingData’ has no member named ‘lightVector’; did you mean ‘directionVector’?
         floatArguments.lightZ = paintingData.lightVector.z();
                                              ^~~~~~~~~~~
                                              directionVector

[Adrian Perez]

For the record, this was trying to build WebKitGTK+ 2.22.2, but I
am quite certain that the issue affects also WPE and is definitely
not fixed in “trunk”.

[Adrian Perez]

This seems to have been broken by r225122 (bug #179933),
which changed the layout of struct PaintaingData.

[Adrian Perez]

Created attachment 350537 [details]
Patch

[Adrian Perez]

I would appreciate if Simon Fraser (who wrote the patch in bug #179933)
and/or Darin Adler (who reviewed it) could take a look at my patch before
landing it (thanks in advance!)

[WebKit Commit Bot]

Comment on attachment 350537 [details]
Patch

Clearing flags on attachment: 350537

Committed r236391: <https://trac.webkit.org/changeset/236391>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44710038>