Bug 189889 - Ensure PointerEvent is not visible when disabled
Summary: Ensure PointerEvent is not visible when disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-22 15:30 PDT by Dean Jackson
Modified: 2018-09-24 10:35 PDT (History)
12 users (show)

See Also:

Attachments
Patch (4.10 KB, patch)
2018-09-22 15:34 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-sierra (2.33 MB, application/zip)
2018-09-22 16:44 PDT, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews112 for mac-sierra (3.03 MB, application/zip)
2018-09-22 17:37 PDT, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews115 for mac-sierra (3.07 MB, application/zip)
2018-09-22 19:39 PDT, EWS Watchlist 		no flags Details
Patch (4.10 KB, patch)
2018-09-22 21:50 PDT, Dean Jackson 		eric.carlson: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2018-09-22 15:30:00 PDT 
Ensure PointerEvent is not visible when disabled
Comment 1 Radar WebKit Bug Importer 2018-09-22 15:30:45 PDT 
<rdar://problem/44708253>
Comment 2 Dean Jackson 2018-09-22 15:34:57 PDT 
Created attachment 350535 [details]
Patch
Comment 3 EWS Watchlist 2018-09-22 16:43:59 PDT 
Comment on attachment 350535 [details]
Patch

Attachment 350535 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9314900

New failing tests:
imported/w3c/web-platform-tests/pointerevents/pointerevent_constructor.html
imported/w3c/web-platform-tests/pointerevents/extension/pointerevent_constructor.html
Comment 4 EWS Watchlist 2018-09-22 16:44:01 PDT 
Created attachment 350538 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 EWS Watchlist 2018-09-22 17:37:02 PDT 
Comment on attachment 350535 [details]
Patch

Attachment 350535 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9315044

New failing tests:
imported/w3c/web-platform-tests/pointerevents/pointerevent_constructor.html
imported/w3c/web-platform-tests/pointerevents/extension/pointerevent_constructor.html
Comment 6 EWS Watchlist 2018-09-22 17:37:04 PDT 
Created attachment 350539 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 7 EWS Watchlist 2018-09-22 19:39:39 PDT 
Comment on attachment 350535 [details]
Patch

Attachment 350535 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9315648

New failing tests:
imported/w3c/web-platform-tests/pointerevents/pointerevent_constructor.html
imported/w3c/web-platform-tests/pointerevents/extension/pointerevent_constructor.html
Comment 8 EWS Watchlist 2018-09-22 19:39:41 PDT 
Created attachment 350544 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 9 Dean Jackson 2018-09-22 21:50:37 PDT 
Created attachment 350550 [details]
Patch
Comment 10 Eric Carlson 2018-09-24 10:00:16 PDT 
Comment on attachment 350550 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350550&action=review

> LayoutTests/pointerevents/disabled.html:7
> +    output.textContent = window.PointerEvent + "";

Nit: a template literal might make this slightly easier to understand: `${window.PointerEvent}`
Comment 11 Dean Jackson 2018-09-24 10:35:53 PDT 
Committed r236410: <https://trac.webkit.org/changeset/236410>