Bug 189881 - WebPageProxy::reattachToWebProcess cleanups
Summary: WebPageProxy::reattachToWebProcess cleanups
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-22 00:54 PDT by Antti Koivisto
Modified: 2018-10-02 09:16 PDT (History)
5 users (show)

See Also:

Attachments
patch (5.72 KB, patch)
2018-09-22 00:58 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (5.72 KB, patch)
2018-09-22 01:49 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (5.72 KB, patch)
2018-09-25 11:17 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2018-09-22 00:54:51 PDT 
Change the factoring to separate swap and crash code paths into different functions.
Comment 1 Antti Koivisto 2018-09-22 00:58:56 PDT 
Created attachment 350502 [details]
patch
Comment 2 Antti Koivisto 2018-09-22 01:49:44 PDT 
Created attachment 350506 [details]
patch
Comment 3 Alex Christensen 2018-09-25 10:40:06 PDT 
Comment on attachment 350506 [details]
patch

The unexpected timeouts in the Mac-wk2 bot are concerning.
Comment 4 Antti Koivisto 2018-09-25 11:16:46 PDT 
I suspect it was unrelated but I can re-EWS this.
Comment 5 Antti Koivisto 2018-09-25 11:17:34 PDT 
Created attachment 350765 [details]
patch
Comment 6 WebKit Commit Bot 2018-10-02 09:15:14 PDT 
Comment on attachment 350765 [details]
patch

Clearing flags on attachment: 350765

Committed r236746: <https://trac.webkit.org/changeset/236746>
Comment 7 WebKit Commit Bot 2018-10-02 09:15:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-10-02 09:16:26 PDT 
<rdar://problem/44940150>