We need to import a JS CBOR coder in order to check responds in layout tests. One of the candidate is: https://github.com/paroga/cbor-js.
<rdar://problem/44701124>
Created attachment 351153 [details] Patch
Comment on attachment 351153 [details] Patch Attachment 351153 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9391951 New failing tests: http/wpt/credential-management/credentialscontainer-store-basics.https.html
Created attachment 351178 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 351208 [details] Patch
Comment on attachment 351208 [details] Patch r=me
(In reply to Chris Dumez from comment #6) > Comment on attachment 351208 [details] > Patch > > r=me Thanks, Chris.
Comment on attachment 351208 [details] Patch Clearing flags on attachment: 351208 Committed r236686: <https://trac.webkit.org/changeset/236686>
All reviewed patches have been landed. Closing bug.
Comment on attachment 351208 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351208&action=review > Source/WebKit/ChangeLog:10 > + as Local's memeber such that tests can pass those certificates to MockLocalConnection instead of letting it memeber -> member > Source/WebKit/ChangeLog:11 > + holds some static ones. holds -> hold > LayoutTests/ChangeLog:9 > + This patch import a 3rd party JS CBOR coder from https://github.com/paroga/cbor-js. imports
Comment on attachment 351208 [details] Patch Oops, it seems too late this time to correct those grammar issues. I will pay more attentions to it next time. Thanks for reviewing, Simon.