Bug 189873 – DisplayList should record and replay back the painting of the form controls

• Status: NEW
• Component: Layout and Rendering

[Said Abou-Hallawa]

The form control drawing will recorded as a paintRect and a callback. If the GraphicsContext is recording, the paintRect and the callback will be stored. Otherwise the callback will be called by passing the GraphicsContext and the paintRect. The callback will be a lambda expression which captures whatever it needs to draw the form control. Since the renderer outlives recording and replaying back the display list, it can be passed by reference.

I am going to enable display list drawing temporarily till the layout tests pass on all bots.

[Said Abou-Hallawa]

Created attachment 350481 [details]
Patch

[EWS Watchlist]

Comment on attachment 350481 [details]
Patch

Attachment 350481 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9307324

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 350487 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 350481 [details]
Patch

Attachment 350481 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9307246

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 350489 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 350481 [details]
Patch

Attachment 350481 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9307460

New failing tests:
imported/mozilla/svg/text-layout-06.svg
displaylists/replay-skip-clipped-rect.html
fast/borders/hidpi-double-border-with-border-radius-always-produce-solid-line.html
fast/css/cascade/box-shadow-and-webkit-box-shadow-cascade-order.html
displaylists/extent-includes-shadow.html
displaylists/extent-includes-transforms.html
mathml/presentation/fractions-color.html
svg/canvas/canvas-global-alpha-svg.html
mathml/presentation/radical-bar-visibility.html
displaylists/layer-dispay-list.html
fast/text/simple-lines-float.html

[EWS Watchlist]

Created attachment 350494 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 350481 [details]
Patch

Attachment 350481 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9308548

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 350500 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Said Abou-Hallawa]

Created attachment 350540 [details]
Patch

[Said Abou-Hallawa]

Created attachment 350542 [details]
Patch

[Said Abou-Hallawa]

Created attachment 350545 [details]
Patch

[Said Abou-Hallawa]

Created attachment 350546 [details]
Patch

[Said Abou-Hallawa]

Created attachment 350547 [details]
Patch

[Said Abou-Hallawa]

Created attachment 350548 [details]
Patch

[Said Abou-Hallawa]

Created attachment 350549 [details]
Patch

[EWS Watchlist]

Comment on attachment 350549 [details]
Patch

Attachment 350549 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9317266

New failing tests:
imported/mozilla/svg/text-layout-06.svg
displaylists/replay-skip-clipped-rect.html
displaylists/extent-includes-shadow.html
fast/css/cascade/box-shadow-and-webkit-box-shadow-cascade-order.html
fast/borders/hidpi-double-border-with-border-radius-always-produce-solid-line.html
displaylists/extent-includes-transforms.html
mathml/presentation/fractions-color.html
svg/canvas/canvas-global-alpha-svg.html
mathml/presentation/radical-bar-visibility.html
displaylists/layer-dispay-list.html
fast/text/simple-lines-float.html

[EWS Watchlist]

Created attachment 350551 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 350549 [details]
Patch

Attachment 350549 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9317360

New failing tests:
imported/mozilla/svg/text-layout-06.svg
displaylists/replay-skip-clipped-rect.html
displaylists/extent-includes-shadow.html
fast/css/cascade/box-shadow-and-webkit-box-shadow-cascade-order.html
fast/borders/hidpi-double-border-with-border-radius-always-produce-solid-line.html
displaylists/extent-includes-transforms.html
mathml/presentation/fractions-color.html
svg/canvas/canvas-global-alpha-svg.html
mathml/presentation/radical-bar-visibility.html
displaylists/layer-dispay-list.html
fast/text/simple-lines-float.html

[EWS Watchlist]

Created attachment 350552 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 350549 [details]
Patch

Attachment 350549 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9317490

New failing tests:
imported/mozilla/svg/text-layout-06.svg
displaylists/replay-skip-clipped-rect.html
fast/borders/hidpi-double-border-with-border-radius-always-produce-solid-line.html
fast/css/cascade/box-shadow-and-webkit-box-shadow-cascade-order.html
displaylists/extent-includes-shadow.html
displaylists/extent-includes-transforms.html
mathml/presentation/fractions-color.html
http/tests/images/draw-pattern-slow-load-large-image.html
svg/canvas/canvas-global-alpha-svg.html
mathml/presentation/radical-bar-visibility.html
displaylists/layer-dispay-list.html
fast/text/simple-lines-float.html

[EWS Watchlist]

Created attachment 350553 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 350549 [details]
Patch

Attachment 350549 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9318084

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 350555 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 350549 [details]
Patch

Attachment 350549 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9318135

New failing tests:
imported/mozilla/svg/text-layout-06.svg
displaylists/replay-skip-clipped-rect.html
displaylists/extent-includes-shadow.html
fast/css/cascade/box-shadow-and-webkit-box-shadow-cascade-order.html
fast/borders/hidpi-double-border-with-border-radius-always-produce-solid-line.html
displaylists/extent-includes-transforms.html
mathml/presentation/fractions-color.html
http/tests/images/draw-pattern-slow-load-large-image.html
svg/canvas/canvas-global-alpha-svg.html
mathml/presentation/radical-bar-visibility.html
displaylists/layer-dispay-list.html
fast/text/simple-lines-float.html

[EWS Watchlist]

Created attachment 350556 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Said Abou-Hallawa]

Created attachment 350612 [details]
Patch

[EWS Watchlist]

Comment on attachment 350612 [details]
Patch

Attachment 350612 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9327476

New failing tests:
imported/mozilla/svg/text-layout-06.svg
displaylists/replay-skip-clipped-rect.html
fast/css/cascade/box-shadow-and-webkit-box-shadow-cascade-order.html
fast/borders/hidpi-double-border-with-border-radius-always-produce-solid-line.html
displaylists/extent-includes-transforms.html
mathml/presentation/fractions-color.html
svg/canvas/canvas-global-alpha-svg.html
mathml/presentation/radical-bar-visibility.html
displaylists/layer-dispay-list.html
fast/text/simple-lines-float.html

[EWS Watchlist]

Created attachment 350619 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 350612 [details]
Patch

Attachment 350612 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9327579

New failing tests:
imported/mozilla/svg/text-layout-06.svg
displaylists/replay-skip-clipped-rect.html
fast/css/cascade/box-shadow-and-webkit-box-shadow-cascade-order.html
fast/borders/hidpi-double-border-with-border-radius-always-produce-solid-line.html
displaylists/extent-includes-transforms.html
mathml/presentation/fractions-color.html
http/tests/images/draw-pattern-slow-load-large-image.html
svg/canvas/canvas-global-alpha-svg.html
mathml/presentation/radical-bar-visibility.html
displaylists/layer-dispay-list.html
fast/text/simple-lines-float.html

[EWS Watchlist]

Created attachment 350623 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 350612 [details]
Patch

Attachment 350612 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9328257

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 350629 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 350612 [details]
Patch

Attachment 350612 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9328409

New failing tests:
imported/mozilla/svg/text-layout-06.svg
displaylists/replay-skip-clipped-rect.html
fast/css/cascade/box-shadow-and-webkit-box-shadow-cascade-order.html
fast/borders/hidpi-double-border-with-border-radius-always-produce-solid-line.html
displaylists/extent-includes-transforms.html
mathml/presentation/fractions-color.html
http/tests/images/draw-pattern-slow-load-large-image.html
svg/canvas/canvas-global-alpha-svg.html
mathml/presentation/radical-bar-visibility.html
displaylists/layer-dispay-list.html
fast/text/simple-lines-float.html

[EWS Watchlist]

Created attachment 350630 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 350612 [details]
Patch

Attachment 350612 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9329005

New failing tests:
imported/mozilla/svg/text-layout-06.svg
fast/css/cascade/box-shadow-and-webkit-box-shadow-cascade-order.html
fast/borders/hidpi-double-border-with-border-radius-always-produce-solid-line.html
mathml/presentation/fractions-color.html
svg/canvas/canvas-global-alpha-svg.html
mathml/presentation/radical-bar-visibility.html
fast/text/simple-lines-float.html

[EWS Watchlist]

Created attachment 350632 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Said Abou-Hallawa]

The last patch confirms that all the layout tests pass when display list drawing is enabled except the following tests:

imported/mozilla/svg/text-layout-06.svg
fast/css/cascade/box-shadow-and-webkit-box-shadow-cascade-order.html
fast/borders/hidpi-double-border-with-border-radius-always-produce-solid-line.html
mathml/presentation/fractions-color.html
svg/canvas/canvas-global-alpha-svg.html
mathml/presentation/radical-bar-visibility.html
fast/text/simple-lines-float.html

These failures are mot related to form controls rendering. So I am going to disable display list drawing back and address these failures in a separate patch.

[Said Abou-Hallawa]

Created attachment 350640 [details]
Patch

[EWS Watchlist]

Comment on attachment 350640 [details]
Patch

Attachment 350640 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9331138

New failing tests:
displaylists/replay-skip-clipped-rect.html
displaylists/extent-includes-transforms.html
displaylists/layer-dispay-list.html

[EWS Watchlist]

Created attachment 350642 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 350640 [details]
Patch

Attachment 350640 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9331171

New failing tests:
displaylists/replay-skip-clipped-rect.html
displaylists/layer-dispay-list.html

[EWS Watchlist]

Created attachment 350645 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 350640 [details]
Patch

Attachment 350640 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9331174

New failing tests:
displaylists/replay-skip-clipped-rect.html
displaylists/extent-includes-transforms.html
displaylists/layer-dispay-list.html

[EWS Watchlist]

Created attachment 350648 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Said Abou-Hallawa]

Created attachment 350656 [details]
Patch

[EWS Watchlist]

Comment on attachment 350656 [details]
Patch

Attachment 350656 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9333491

New failing tests:
displaylists/extent-includes-transforms.html

[EWS Watchlist]

Created attachment 350667 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 350656 [details]
Patch

Attachment 350656 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9333526

New failing tests:
displaylists/extent-includes-transforms.html

[EWS Watchlist]

Created attachment 350673 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Said Abou-Hallawa]

Created attachment 350707 [details]
Patch for review