Bug 189872 - Video track clone cannot preserve original property
Summary: Video track clone cannot preserve original property
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wendy
Keywords: InRadar
Depends on:
Reported: 2018-09-21 18:50 PDT by Wendy
Modified: 2018-09-26 18:42 PDT (History)
5 users (show)

See Also:

Patch (7.11 KB, patch)
2018-09-26 16:16 PDT, Wendy
no flags Details | Formatted Diff | Diff
Patch (6.47 KB, patch)
2018-09-26 17:15 PDT, Wendy
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wendy 2018-09-21 18:50:45 PDT
use canvas.captureStream to create a video track, and the cloned track will not keep the property such as enabled compared with original track.
Comment 1 Radar WebKit Bug Importer 2018-09-22 11:19:32 PDT
Comment 2 Wendy 2018-09-26 16:16:23 PDT
Created attachment 350920 [details]
Comment 3 youenn fablet 2018-09-26 16:41:14 PDT
Comment on attachment 350920 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=350920&action=review

> Source/WebCore/ChangeLog:8
> +

Can you provide more information about changes?
For instance describe what was the issue.

> Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.h:43
> +    static Ref<CanvasCaptureMediaStreamTrack> create(ScriptExecutionContext&, Ref<HTMLCanvasElement>&&, Ref<MediaStreamTrackPrivate>&& privateTrack);

It might be good to not define this create() method and directly call adoptRef(*new ...) in CanvasCaptureMediaStreamTrack::clone().
Comment 4 Wendy 2018-09-26 17:15:14 PDT
Created attachment 350927 [details]
Comment 5 WebKit Commit Bot 2018-09-26 18:42:31 PDT
Comment on attachment 350927 [details]

Clearing flags on attachment: 350927

Committed r236536: <https://trac.webkit.org/changeset/236536>
Comment 6 WebKit Commit Bot 2018-09-26 18:42:33 PDT
All reviewed patches have been landed.  Closing bug.