Bug 189868 - [MSE][GStreamer] Use no-more-pads event for noticing initialization segments
Summary: [MSE][GStreamer] Use no-more-pads event for noticing initialization segments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-21 16:59 PDT by Alicia Boya García
Modified: 2018-09-24 06:31 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.75 KB, patch)
2018-09-21 17:00 PDT, Alicia Boya García 		no flags Details | Formatted Diff | Diff
Patch (11.18 KB, patch)
2018-09-24 05:44 PDT, Alicia Boya García 		no flags Details | Formatted Diff | Diff
Patch (11.18 KB, patch)
2018-09-24 05:52 PDT, Alicia Boya García 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2018-09-21 16:59:18 PDT 
Fixes the following YTTV 2018 tests:
62.VideoDimensionVP9
63.PlaybackStateVP9

This removes the hack that was making supporting multiple tracks in
the same file in MSE impossible.

For WebM, this GStreamer patch is required:
https://bugzilla.gnome.org/show_bug.cgi?id=797187
"matroskademux: Emit no-more-pads after parsing Tracks"
Comment 1 Alicia Boya García 2018-09-21 17:00:20 PDT 
Created attachment 350458 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2018-09-23 22:50:28 PDT 
Comment on attachment 350458 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350458&action=review

> Source/WebCore/ChangeLog:17
> +        For WebM, this GStreamer patch is required:
> +        https://bugzilla.gnome.org/show_bug.cgi?id=797187
> +        "matroskademux: Emit no-more-pads after parsing Tracks"

Why are you not including this patch as part of our JHBuild conf?
Comment 3 Alicia Boya García 2018-09-24 05:44:26 PDT 
Created attachment 350634 [details]
Patch
Comment 4 Alicia Boya García 2018-09-24 05:52:39 PDT 
Created attachment 350635 [details]
Patch
Comment 5 WebKit Commit Bot 2018-09-24 06:31:27 PDT 
Comment on attachment 350635 [details]
Patch

Clearing flags on attachment: 350635

Committed r236399: <https://trac.webkit.org/changeset/236399>
Comment 6 WebKit Commit Bot 2018-09-24 06:31:28 PDT 
All reviewed patches have been landed.  Closing bug.