Bug 189863 - Import html/webappapis/dynamic-markup-insertion WPT tests
Summary: Import html/webappapis/dynamic-markup-insertion WPT tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 189917 189373
  Show dependency tree / graph
 
Reported: 2018-09-21 15:24 PDT by Chris Dumez
Modified: 2018-09-24 12:42 PDT (History)
6 users (show)

See Also:

Attachments
Patch (431.71 KB, patch)
2018-09-21 15:31 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews112 for mac-sierra (3.52 MB, application/zip)
2018-09-21 18:37 PDT, EWS Watchlist 		no flags Details
Patch (432.23 KB, patch)
2018-09-24 08:52 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-09-21 15:24:54 PDT 
Import html/webappapis/dynamic-markup-insertion WPT tests.
Comment 1 Chris Dumez 2018-09-21 15:31:42 PDT 
Created attachment 350442 [details]
Patch
Comment 2 youenn fablet 2018-09-21 15:51:31 PDT 
Comment on attachment 350442 [details]
Patch

r=me once bots are happy
Comment 3 EWS Watchlist 2018-09-21 18:37:51 PDT 
Comment on attachment 350442 [details]
Patch

Attachment 350442 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9305353

New failing tests:
imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/document-write/contentType.window.html
Comment 4 EWS Watchlist 2018-09-21 18:37:54 PDT 
Created attachment 350469 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 Chris Dumez 2018-09-24 08:52:11 PDT 
Created attachment 350641 [details]
Patch
Comment 6 WebKit Commit Bot 2018-09-24 09:55:38 PDT 
Comment on attachment 350641 [details]
Patch

Clearing flags on attachment: 350641

Committed r236405: <https://trac.webkit.org/changeset/236405>
Comment 7 WebKit Commit Bot 2018-09-24 09:55:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-09-24 09:56:28 PDT 
<rdar://problem/44729460>
Comment 9 Truitt Savell 2018-09-24 12:34:15 PDT 
Looks like the Newley imported test imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/document-write/contentType.window.html

Imported in: https://trac.webkit.org/changeset/236405/webkit

is a flakey timeout. 

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fwebappapis%2Fdynamic-markup-insertion%2Fdocument-write%2FcontentType.window.html
Comment 10 Chris Dumez 2018-09-24 12:39:00 PDT 
(In reply to Truitt Savell from comment #9)
> Looks like the Newley imported test
> imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/
> document-write/contentType.window.html
> 
> Imported in: https://trac.webkit.org/changeset/236405/webkit
> 
> is a flakey timeout. 
> 
> History:
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-
> tests%2Fhtml%2Fwebappapis%2Fdynamic-markup-insertion%2Fdocument-
> write%2FcontentType.window.html

And I already knew it was crashing in Debug (see associated bug). I'll skip it until I can investigate.
Comment 11 Chris Dumez 2018-09-24 12:42:43 PDT 
(In reply to Chris Dumez from comment #10)
> (In reply to Truitt Savell from comment #9)
> > Looks like the Newley imported test
> > imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/
> > document-write/contentType.window.html
> > 
> > Imported in: https://trac.webkit.org/changeset/236405/webkit
> > 
> > is a flakey timeout. 
> > 
> > History:
> > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> > html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-
> > tests%2Fhtml%2Fwebappapis%2Fdynamic-markup-insertion%2Fdocument-
> > write%2FcontentType.window.html
> 
> And I already knew it was crashing in Debug (see associated bug). I'll skip
> it until I can investigate.

<https://trac.webkit.org/changeset/236419>