Bug 189860 - Web Inspector: determine hasVisibleEffect for each RecordingAction as it's processed
Summary: Web Inspector: determine hasVisibleEffect for each RecordingAction as it's pr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: WebInspectorCanvasRecording WebInspectorCanvasTab
  Show dependency tree / graph
 
Reported: 2018-09-21 15:02 PDT by Devin Rousso
Modified: 2018-09-26 23:10 PDT (History)
4 users (show)

See Also:

Attachments
Patch (18.32 KB, patch)
2018-09-21 15:27 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (19.05 KB, patch)
2018-09-26 22:31 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2018-09-21 15:02:24 PDT 
Ever since <https://webkit.org/b/185152>, we now process recordings in a much more non-blocking way, meaning that we can do a bit more work for each action.  As such, we should attempt to determine `hasVisibleEffect` during this time, as if the experimental flag created in <https://webkit.org/b/185758> was always enabled.
Comment 1 Devin Rousso 2018-09-21 15:27:15 PDT 
Created attachment 350441 [details]
Patch
Comment 2 Joseph Pecoraro 2018-09-26 16:44:32 PDT 
Comment on attachment 350441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350441&action=review

r=me, nice!

> Source/WebInspectorUI/UserInterface/Base/Utilities.js:430
> +        function isArray(x) {

How about naming this `isArrayLike` or `isNativeArrayType`
Comment 3 Devin Rousso 2018-09-26 22:31:28 PDT 
Created attachment 350943 [details]
Patch
Comment 4 WebKit Commit Bot 2018-09-26 23:09:55 PDT 
Comment on attachment 350943 [details]
Patch

Clearing flags on attachment: 350943

Committed r236539: <https://trac.webkit.org/changeset/236539>
Comment 5 WebKit Commit Bot 2018-09-26 23:09:57 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-09-26 23:10:23 PDT 
<rdar://problem/44820587>