Bug 189854 - Import WPT content hint tests
Summary: Import WPT content hint tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wendy
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-21 13:31 PDT by Wendy
Modified: 2018-09-25 11:55 PDT (History)
5 users (show)

See Also:

Attachments
Patch (10.42 KB, patch)
2018-09-21 13:33 PDT, Wendy 		no flags Details | Formatted Diff | Diff
Patch (10.37 KB, patch)
2018-09-21 14:57 PDT, Wendy 		no flags Details | Formatted Diff | Diff
Patch (11.54 KB, patch)
2018-09-24 12:08 PDT, Wendy 		no flags Details | Formatted Diff | Diff
Patch (11.42 KB, patch)
2018-09-24 12:17 PDT, Wendy 		no flags Details | Formatted Diff | Diff
Patch (2.15 KB, patch)
2018-09-24 13:37 PDT, Wendy 		no flags Details | Formatted Diff | Diff
Patch (1.73 KB, patch)
2018-09-25 11:04 PDT, Wendy 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wendy 2018-09-21 13:31:21 PDT 
import a contentment test case from W3C
Comment 1 Wendy 2018-09-21 13:33:40 PDT 
Created attachment 350416 [details]
Patch
Comment 2 youenn fablet 2018-09-21 13:34:39 PDT 
Comment on attachment 350416 [details]
Patch

r=me.
Let's land it once bots are green.
Comment 3 youenn fablet 2018-09-21 14:02:08 PDT 
Bug title should be renamed to "Import WPT content hint tests".
ChangeLog does not need "expected result" and "new-tests" lines.
Comment 4 Wendy 2018-09-21 14:57:49 PDT 
Created attachment 350434 [details]
Patch
Comment 5 WebKit Commit Bot 2018-09-21 16:06:49 PDT 
Comment on attachment 350434 [details]
Patch

Clearing flags on attachment: 350434

Committed r236367: <https://trac.webkit.org/changeset/236367>
Comment 6 WebKit Commit Bot 2018-09-21 16:06:50 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-09-21 16:07:26 PDT 
<rdar://problem/44695832>
Comment 8 Truitt Savell 2018-09-21 17:23:51 PDT 
After https://trac.webkit.org/changeset/236367/webkit

the new test imported/w3c/web-platform-tests/mst-content-hint/idlharness.window.html

does not have an expectation file and is showing missing results in history

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fmst-content-hint%2Fidlharness.window.html
Comment 9 Wendy 2018-09-24 12:08:53 PDT 
Reopening to attach new patch.
Comment 10 Wendy 2018-09-24 12:08:54 PDT 
Created attachment 350659 [details]
Patch
Comment 11 Wendy 2018-09-24 12:17:43 PDT 
Created attachment 350660 [details]
Patch
Comment 12 Wendy 2018-09-24 13:37:10 PDT 
Created attachment 350677 [details]
Patch
Comment 13 youenn fablet 2018-09-24 21:27:13 PDT 
Comment on attachment 350677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350677&action=review

> LayoutTests/imported/w3c/ChangeLog:14
> +        * web-platform-tests/mst-content-hint/w3c-import.log: Added.

The change log is not right here.
It should only contain the following line:
        * imported/w3c/web-platform-tests/mst-content-hint/idlharness.window-expected.txt
Comment 14 Wendy 2018-09-25 11:04:04 PDT 
Created attachment 350763 [details]
Patch
Comment 15 WebKit Commit Bot 2018-09-25 11:55:33 PDT 
Comment on attachment 350763 [details]
Patch

Clearing flags on attachment: 350763

Committed r236467: <https://trac.webkit.org/changeset/236467>
Comment 16 WebKit Commit Bot 2018-09-25 11:55:35 PDT 
All reviewed patches have been landed.  Closing bug.