Bug 189850 - Deprecate ObjC SPI in Deprecated Xcode group
Summary: Deprecate ObjC SPI in Deprecated Xcode group
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-21 12:32 PDT by Alex Christensen
Modified: 2018-10-01 12:58 PDT (History)
3 users (show)

See Also:


Attachments
Patch (39.26 KB, patch)
2018-09-21 14:03 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (40.81 KB, patch)
2018-09-24 16:38 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (41.70 KB, patch)
2018-09-24 17:05 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (43.82 KB, patch)
2018-09-24 22:49 PDT, Alex Christensen
aestes: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-09-21 12:32:39 PDT
Deprecate ObjC SPI in Deprecated Xcode group
Comment 1 Alex Christensen 2018-09-21 14:03:30 PDT
Created attachment 350420 [details]
Patch
Comment 2 Alex Christensen 2018-09-24 16:38:31 PDT
Created attachment 350710 [details]
Patch
Comment 3 Alex Christensen 2018-09-24 17:05:34 PDT
Created attachment 350712 [details]
Patch
Comment 4 Alex Christensen 2018-09-24 22:49:10 PDT
Created attachment 350739 [details]
Patch
Comment 5 Andy Estes 2018-09-27 15:16:45 PDT
Comment on attachment 350739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350739&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextGroup.h:33
> -WK_CLASS_AVAILABLE(macosx(10.10), ios(8.0))
> +WK_CLASS_DEPRECATED_WITH_REPLACEMENT("WKUserContentController", macos(10.10, WK_MAC_TBA), ios(8.0, WK_IOS_TBA))

Seems like this was a weird mix of user content and preferences. I guess there is no single replacement in the modern API; should you mention WKPreferences as well?
Comment 6 Alex Christensen 2018-10-01 10:17:07 PDT
http://trac.webkit.org/r236665
Comment 7 Radar WebKit Bug Importer 2018-10-01 10:18:22 PDT
<rdar://problem/44912137>
Comment 8 Alex Christensen 2018-10-01 11:27:44 PDT
http://trac.webkit.org/r236675
Comment 9 Alex Christensen 2018-10-01 12:58:02 PDT
http://trac.webkit.org/r236687