Bug 189844 – [GTK] ANGLE's eglplatform.h does not support Wayland-only builds

• Status: RESOLVED
• Resolution: FIXED
• Component: ANGLE

[Adrian Perez]

The latest ANGLE update (from r225340) is causing another instance
of bug #163482

The upstream maintainers decided to apply their own version of the
patch that I had attached in the upstream bug, which lacks one of the
hunks from the patch I had uploaded. This is the upstream bug report:

  https://bugs.chromium.org/p/angleproject/issues/detail?id=2105

The missing bits *are* needed, so let's re-add them. I will give it
a try to have also the changes upstream later on.

[Adrian Perez]

Created attachment 350399 [details]
Patch

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE

[Adrian Perez]

JFTR, I have successfully tested this using Buildroot to compile
an image for the RaspberryPi 3 configured with Wayland, no X11,
and WebKitGTK+ (both “trunk” and 2.22.1 — the patch applies
cleanly on the stable release).

[Michael Catanzaro]

Comment on attachment 350399 [details]
Patch

r=me provided you try again to upstream this.

[WebKit Commit Bot]

Comment on attachment 350399 [details]
Patch

Clearing flags on attachment: 350399

Committed r236349: <https://trac.webkit.org/changeset/236349>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44689720>

[Adrian Perez]

(In reply to Michael Catanzaro from comment #4)
> Comment on attachment 350399 [details]
> Patch
> 
> r=me provided you try again to upstream this.

Indeed! I had opened an issue upstream, but forgot to mentioned it here:

    https://bugs.chromium.org/p/angleproject/issues/detail?id=2839

Let's see if this time upstream adopts the full patch instead of merging
a half-baked version (which is what happened last time).

[Pablo Saavedra]

This change is not longer there (not at least in WebKitGTK/WPEWebKit 2.36.0). I think that was removed by a later ANGLE new version rollout.

[Adrian Perez]

(In reply to Pablo Saavedra from comment #9)
> This change is not longer there (not at least in WebKitGTK/WPEWebKit
> 2.36.0). I think that was removed by a later ANGLE new version rollout.

Right, nowadays we define USE_SYSTEM_EGL for building ANGLE, which gets
us the same net result without needing to maintain changes to ANGLE :)