Bug 189843 – [MediaStream] Add mock window capture source

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[Eric Carlson]

Add Mac and mock window capture sources

[Radar WebKit Bug Importer]

<rdar://problem/44687445>

[Eric Carlson]

Created attachment 350541 [details]
Patch

[EWS Watchlist]

Attachment 350541 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/mac/WindowDisplayCaptureSourceMac.mm:43:  *SoftLink.h header should be included after all other headers.  [build/include_order] [4]
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Carlson]

Created attachment 350569 [details]
Patch

[EWS Watchlist]

Comment on attachment 350569 [details]
Patch

Attachment 350569 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9322641

New failing tests:
http/tests/media/media-stream/get-display-media-prompt.html

[EWS Watchlist]

Created attachment 350583 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Eric Carlson]

Created attachment 350664 [details]
Patch

[youenn fablet]

Comment on attachment 350664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350664&action=review

> Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:142
> +    return RealtimeMediaSource::supportsSizeAndFrameRate(width, height, rate);

That seems a bit odd here and below, Is there a way to improve things here?

[Eric Carlson]

Created attachment 350671 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 350671 [details]
Patch for landing

Clearing flags on attachment: 350671

Committed r236422: <https://trac.webkit.org/changeset/236422>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.