Bug 189843 - [MediaStream] Add mock window capture source
Summary: [MediaStream] Add mock window capture source
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-21 11:42 PDT by Eric Carlson
Modified: 2018-09-24 13:13 PDT (History)
5 users (show)

See Also:


Attachments
Patch (66.56 KB, patch)
2018-09-22 19:02 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
Patch (66.65 KB, patch)
2018-09-23 09:15 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.05 MB, application/zip)
2018-09-23 12:38 PDT, EWS Watchlist
no flags Details
Patch (16.14 KB, patch)
2018-09-24 12:25 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
Patch for landing (16.47 KB, patch)
2018-09-24 12:53 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2018-09-21 11:42:17 PDT
Add Mac and mock window capture sources
Comment 1 Radar WebKit Bug Importer 2018-09-21 11:42:52 PDT
<rdar://problem/44687445>
Comment 2 Eric Carlson 2018-09-22 19:02:18 PDT
Created attachment 350541 [details]
Patch
Comment 3 EWS Watchlist 2018-09-22 19:04:22 PDT
Attachment 350541 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/mac/WindowDisplayCaptureSourceMac.mm:43:  *SoftLink.h header should be included after all other headers.  [build/include_order] [4]
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Eric Carlson 2018-09-23 09:15:24 PDT
Created attachment 350569 [details]
Patch
Comment 5 EWS Watchlist 2018-09-23 12:38:00 PDT
Comment on attachment 350569 [details]
Patch

Attachment 350569 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9322641

New failing tests:
http/tests/media/media-stream/get-display-media-prompt.html
Comment 6 EWS Watchlist 2018-09-23 12:38:01 PDT
Created attachment 350583 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 7 Eric Carlson 2018-09-24 12:25:24 PDT
Created attachment 350664 [details]
Patch
Comment 8 youenn fablet 2018-09-24 12:31:09 PDT
Comment on attachment 350664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350664&action=review

> Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:142
> +    return RealtimeMediaSource::supportsSizeAndFrameRate(width, height, rate);

That seems a bit odd here and below, Is there a way to improve things here?
Comment 9 Eric Carlson 2018-09-24 12:53:58 PDT
Created attachment 350671 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2018-09-24 13:13:04 PDT
Comment on attachment 350671 [details]
Patch for landing

Clearing flags on attachment: 350671

Committed r236422: <https://trac.webkit.org/changeset/236422>
Comment 11 WebKit Commit Bot 2018-09-24 13:13:05 PDT
All reviewed patches have been landed.  Closing bug.