Bug 18984 - [GTK] textarea height property works only if other property are defined
Summary: [GTK] textarea height property works only if other property are defined
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2008-05-10 03:16 PDT by arno.
Modified: 2009-07-07 08:53 PDT (History)
2 users (show)

See Also:


Attachments
testcase (309 bytes, text/html)
2008-05-10 03:17 PDT, arno.
no flags Details
patch (3.19 KB, patch)
2009-07-07 08:18 PDT, Jan Alonzo
gustavo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description arno. 2008-05-10 03:16:40 PDT
Hi,
When you set height property to a textarea, it is not taken into account.
To make height property work, you must set other properties, such as border, or background-color.
Comment 1 arno. 2008-05-10 03:17:50 PDT
Created attachment 21055 [details]
testcase
Comment 2 Dirk Schulze 2008-05-10 03:58:55 PDT
The same here. But it is only related to WebKitGtk. Changed the report.
Comment 3 Jan Alonzo 2009-07-07 08:18:22 PDT
Created attachment 32378 [details]
patch
Comment 4 Gustavo Noronha (kov) 2009-07-07 08:35:12 PDT
Comment on attachment 32378 [details]
patch

Thanks for looking into this! It makes me sad =). I believe leaving this for webcore to do is not really what we want; we probably want to do the same as adjustTextFieldStyle, except for setting the height to auto. I'll say r- on that basis.
Comment 5 Gustavo Noronha (kov) 2009-07-07 08:44:16 PDT
Comment on attachment 32378 [details]
patch

After clarifying a few concerns with Jan regarding the effect this had in things such as dark themes, I now believe this is correct, so I'll say r=me.
Comment 6 Jan Alonzo 2009-07-07 08:53:10 PDT
(In reply to comment #5)
> (From update of attachment 32378 [details])
> After clarifying a few concerns with Jan regarding the effect this had in
> things such as dark themes, I now believe this is correct, so I'll say r=me.

Thanks. Landed in r45595.