Bug 189835 – [WPE][GTK][WebRTC] Fix leaks in the libwebrtc Decoder and Encoder

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Thibault Saunier]

[WPE][GTK][WebRTC] Fix leaks in the libwebrtc Decoder and Encoder

[Thibault Saunier]

Created attachment 350369 [details]
Patch

[EWS Watchlist]

Attachment 350369 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Thibault Saunier]

Created attachment 350374 [details]
Patch

[Philippe Normand]

Comment on attachment 350374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350374&action=review

> Source/WebCore/ChangeLog:9
> +          startegy as other libwebrtc encoder implementation).

tyop: startegy ;)

> Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:84
>          SetRestrictionCaps(caps);

Would it be better to understand if SetRestrictionCaps() was taking a GRefPtr instead of a raw pointer?

> Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:110
> +        m_encodedFrame._size = codecSettings->width * codecSettings->height * 3;

3 is for the number of planes I assume? Is this info stored in the codec settings maybe?

[Thibault Saunier]

(In reply to Philippe Normand from comment #4)
> Comment on attachment 350374 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=350374&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +          startegy as other libwebrtc encoder implementation).
> 
> tyop: startegy ;)

Fixed.

> > Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:84
> >          SetRestrictionCaps(caps);
> 
> Would it be better to understand if SetRestrictionCaps() was taking a
> GRefPtr instead of a raw pointer?

Fixed.

> > Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:110
> > +        m_encodedFrame._size = codecSettings->width * codecSettings->height * 3;
> 
> 3 is for the number of planes I assume? Is this info stored in the codec
> settings maybe?

It doesn't seem to contain any info about that, I just reused what they did for the openh264 encoder.

[Thibault Saunier]

Created attachment 350395 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 350395 [details]
Patch

Clearing flags on attachment: 350395

Committed r236397: <https://trac.webkit.org/changeset/236397>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44723922>