Bug 189831 - [ARM] Build broken on armv7hl after r235517
Summary: [ARM] Build broken on armv7hl after r235517
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tomas Popela
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-21 07:25 PDT by Tomas Popela
Modified: 2018-09-21 07:36 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.74 KB, patch)
2018-09-21 07:27 PDT, Tomas Popela
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Popela 2018-09-21 07:25:55 PDT
It's broken because of the missing implementation of patchableBranch8(). Fro ARMV7 it was added by Mark in https://trac.webkit.org/r235557, but the implementation for traditional ARM is still missing.
Comment 1 Tomas Popela 2018-09-21 07:27:32 PDT
Created attachment 350359 [details]
Patch
Comment 2 Yusuke Suzuki 2018-09-21 07:30:42 PDT
Comment on attachment 350359 [details]
Patch

r=me as a build fix.
Comment 3 Tomas Popela 2018-09-21 07:35:45 PDT
Comment on attachment 350359 [details]
Patch

Clearing flags on attachment: 350359

Committed r236315: <https://trac.webkit.org/changeset/236315>
Comment 4 Tomas Popela 2018-09-21 07:35:50 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-09-21 07:36:20 PDT
<rdar://problem/44679245>