Bug 189823 - TransformationMatrix::toColumnMajorFloatArray() should return a std::array<> object
Summary: TransformationMatrix::toColumnMajorFloatArray() should return a std::array<> ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-21 03:09 PDT by Zan Dobersek
Modified: 2018-09-21 05:48 PDT (History)
7 users (show)

See Also:

Attachments
Patch (6.54 KB, patch)
2018-09-21 03:12 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (6.54 KB, patch)
2018-09-21 04:05 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2018-09-21 03:09:42 PDT 
TransformationMatrix::toColumnMajorFloatArray() should return a std::array<> object
Comment 1 Zan Dobersek 2018-09-21 03:12:08 PDT 
Created attachment 350345 [details]
Patch
Comment 2 Zan Dobersek 2018-09-21 04:05:35 PDT 
Created attachment 350348 [details]
Patch
Comment 3 Michael Catanzaro 2018-09-21 04:27:01 PDT 
Comment on attachment 350348 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350348&action=review

> Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:1727
> -void TransformationMatrix::toColumnMajorFloatArray(FloatMatrix4& result) const
> +auto TransformationMatrix::toColumnMajorFloatArray() const -> FloatMatrix4

Wow, a good use of the trailing return syntax...
Comment 4 Zan Dobersek 2018-09-21 05:47:47 PDT 
Comment on attachment 350348 [details]
Patch

Clearing flags on attachment: 350348

Committed r236311: <https://trac.webkit.org/changeset/236311>
Comment 5 Zan Dobersek 2018-09-21 05:47:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-09-21 05:48:23 PDT 
<rdar://problem/44677771>