Bug 189819 - Implement initialValue support for CSS Custom Properties and Values API
Summary: Implement initialValue support for CSS Custom Properties and Values API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 189692
  Show dependency treegraph
 
Reported: 2018-09-20 22:44 PDT by Justin Michaud
Modified: 2018-09-21 19:53 PDT (History)
8 users (show)

See Also:


Attachments
Patch (36.36 KB, patch)
2018-09-20 22:51 PDT, Justin Michaud
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews200 for win-future (13.05 MB, application/zip)
2018-09-21 02:57 PDT, Build Bot
no flags Details
Patch (37.00 KB, patch)
2018-09-21 16:58 PDT, Justin Michaud
no flags Details | Formatted Diff | Diff
Patch (37.12 KB, patch)
2018-09-21 17:21 PDT, Justin Michaud
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Michaud 2018-09-20 22:44:17 PDT
Support setting initialValue for custom properties
Comment 1 Justin Michaud 2018-09-20 22:51:41 PDT
Created attachment 350331 [details]
Patch
Comment 2 Build Bot 2018-09-21 02:57:01 PDT
Comment on attachment 350331 [details]
Patch

Attachment 350331 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9293702

New failing tests:
css-custom-properties-api/initialValue.html
css-custom-properties-api/initialValueJS.html
Comment 3 Build Bot 2018-09-21 02:57:13 PDT
Created attachment 350344 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 Justin Michaud 2018-09-21 16:58:45 PDT
Created attachment 350456 [details]
Patch
Comment 5 Justin Michaud 2018-09-21 17:21:40 PDT
Created attachment 350461 [details]
Patch
Comment 6 WebKit Commit Bot 2018-09-21 18:03:57 PDT
Comment on attachment 350461 [details]
Patch

Clearing flags on attachment: 350461

Committed r236379: <https://trac.webkit.org/changeset/236379>
Comment 7 WebKit Commit Bot 2018-09-21 18:04:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-09-21 18:05:07 PDT
<rdar://problem/44698845>
Comment 9 Ryosuke Niwa 2018-09-21 19:53:13 PDT
Comment on attachment 350461 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350461&action=review

> Source/WebCore/css/CSSRegisteredCustomProperty.h:40
> +using CSSRegisteredCustomPropertySet = HashMap<String, std::unique_ptr<CSSRegisteredCustomProperty>>;

It's weird to call HashMap a set. We should probably rename this to CSSRegisteredCustomPropertyMap.