Bug 189818 - [macOS EWS] Layout test accessibility/smart-invert-reference.html is a flaky failure
Summary: [macOS EWS] Layout test accessibility/smart-invert-reference.html is a flaky ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-20 20:58 PDT by Ryan Haddad
Modified: 2019-04-09 13:14 PDT (History)
14 users (show)

See Also:


Attachments
EWS results (3.91 MB, application/zip)
2018-09-20 20:58 PDT, Ryan Haddad
no flags Details
expected image (75.59 KB, image/png)
2018-09-20 21:01 PDT, Ryan Haddad
no flags Details
diff (2.41 KB, image/png)
2018-09-20 21:01 PDT, Ryan Haddad
no flags Details
Patch (5.84 KB, patch)
2019-01-03 15:56 PST, Aaron Chu
ap: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2018-09-20 20:58:02 PDT
Layout test accessibility/smart-invert-reference.html is a flaky failure on macOS EWS bots, frequently causing false positives.

Examples of bugs where this test has caused a false positive:
https://bugs.webkit.org/buglist.cgi?quicksearch=accessibility%2Fsmart-invert-reference.html&list_id=4093847
Comment 1 Ryan Haddad 2018-09-20 20:58:56 PDT
Created attachment 350320 [details]
EWS results
Comment 2 Ryan Haddad 2018-09-20 21:01:10 PDT
Created attachment 350321 [details]
expected image
Comment 3 Ryan Haddad 2018-09-20 21:01:20 PDT
Created attachment 350322 [details]
diff
Comment 4 Ryan Haddad 2018-09-20 21:07:14 PDT
(In reply to Ryan Haddad from comment #3)
> Created attachment 350322 [details]
> diff
This diff shows that the failure is due to a blur around three play buttons.
Comment 6 Radar WebKit Bug Importer 2018-09-20 21:10:10 PDT
<rdar://problem/44667625>
Comment 7 Ryan Haddad 2018-09-21 17:18:35 PDT
Marked test as flaky in https://trac.webkit.org/r236377

We need to try to reproduce this locally.
Comment 8 Aaron Chu 2019-01-03 15:56:40 PST
Created attachment 358283 [details]
Patch
Comment 9 Alexey Proskuryakov 2019-01-03 16:15:06 PST
Comment on attachment 358283 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358283&action=review

> LayoutTests/ChangeLog:9
> +        Swapped out the blur effect image behind the video play buttons for a solid color image to enhance rendering consistency.

Did you figure out what was the cause of flakiness specifically? We don't generally have any randomness in painting. One common case for varying results is state leaking from previous tests, and that's something that would need to be fixed if that's the case here.
Comment 10 Alexey Proskuryakov 2019-04-09 12:55:02 PDT
Comment on attachment 358283 [details]
Patch

Shown found repro steps (see radar), and confirmed that the issue still occurs with this patch applied.