NEW189818
accessibility/smart-invert-reference.html is a flaky failure, always fails when run after rebooting 
https://bugs.webkit.org/show_bug.cgi?id=189818
Summary accessibility/smart-invert-reference.html is a flaky failure, always fails wh...
Ryan Haddad
Reported 2018-09-20 20:58:02 PDT
Layout test accessibility/smart-invert-reference.html is a flaky failure on macOS EWS bots, frequently causing false positives. Examples of bugs where this test has caused a false positive: https://bugs.webkit.org/buglist.cgi?quicksearch=accessibility%2Fsmart-invert-reference.html&list_id=4093847
Attachments
EWS results (3.91 MB, application/zip)
2018-09-20 20:58 PDT, Ryan Haddad 		no flags
Details
expected image (75.59 KB, image/png)
2018-09-20 21:01 PDT, Ryan Haddad 		no flags
Details
diff (2.41 KB, image/png)
2018-09-20 21:01 PDT, Ryan Haddad 		no flags
Details
Patch (5.84 KB, patch)
2019-01-03 15:56 PST, Aaron Chu 		ap: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2018-09-20 20:58:56 PDT
Created attachment 350320 [details] EWS results
Ryan Haddad
Comment 2 2018-09-20 21:01:10 PDT
Created attachment 350321 [details] expected image
Ryan Haddad
Comment 3 2018-09-20 21:01:20 PDT
Created attachment 350322 [details] diff
Ryan Haddad
Comment 4 2018-09-20 21:07:14 PDT
(In reply to Ryan Haddad from comment #3) > Created attachment 350322 [details] > diff This diff shows that the failure is due to a blur around three play buttons.
Radar WebKit Bug Importer
Comment 6 2018-09-20 21:10:10 PDT
<rdar://problem/44667625>
Ryan Haddad
Comment 7 2018-09-21 17:18:35 PDT
Marked test as flaky in https://trac.webkit.org/r236377 We need to try to reproduce this locally.
Aaron Chu
Comment 8 2019-01-03 15:56:40 PST
Created attachment 358283 [details] Patch
Alexey Proskuryakov
Comment 9 2019-01-03 16:15:06 PST
Comment on attachment 358283 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358283&action=review > LayoutTests/ChangeLog:9 > + Swapped out the blur effect image behind the video play buttons for a solid color image to enhance rendering consistency. Did you figure out what was the cause of flakiness specifically? We don't generally have any randomness in painting. One common case for varying results is state leaking from previous tests, and that's something that would need to be fixed if that's the case here.
Alexey Proskuryakov
Comment 10 2019-04-09 12:55:02 PDT
Comment on attachment 358283 [details] Patch Shown found repro steps (see radar), and confirmed that the issue still occurs with this patch applied.
Alexey Proskuryakov
Comment 11 2019-12-22 12:11:48 PST
*** Bug 205308 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.