WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
189815
check-webkit-style complains about weird indentation when line has leading C-style comment
https://bugs.webkit.org/show_bug.cgi?id=189815
Summary
check-webkit-style complains about weird indentation when line has leading C-...
Daniel Bates
Reported
2018-09-20 20:08:31 PDT
Consider the following code: 0. int windowsKeyCodeForKeyCode(uint16_t keyCode) 1. { 2. static const int windowsKeyCode[] = { 3. /* 0 */ VK_A, 4. } 5. return 0; 6. } check-webkit-style complains that line 3 has a "Weird number of spaces at line-start. Are you using a 4-space indent?" even though the start of the C-style comment is on a 4 space boundary. Compare the behavior to this code: 0. int windowsKeyCodeForKeyCode(uint16_t keyCode) 1. { 2. static const int windowsKeyCode[] = { 3. VK_A, 4. } 5. return 0; 6. }
Attachments
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2018-09-20 20:14:51 PDT
I hit this issue when running check-webkit-style against
attachment #350311
[details]
(
bug #189604
).
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug