RESOLVED FIXED 189812
Restrict the total combined size of backdrop filters 
https://bugs.webkit.org/show_bug.cgi?id=189812
Summary Restrict the total combined size of backdrop filters
Dean Jackson
Reported 2018-09-20 18:12:28 PDT
Restrict the total combined size of backdrop filters
Attachments
Patch (27.86 KB, patch)
2018-09-20 18:24 PDT, Dean Jackson 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2018-09-20 18:12:54 PDT
<rdar://problem/44532782>
Dean Jackson
Comment 2 2018-09-20 18:24:11 PDT
Created attachment 350296 [details] Patch
mitz
Comment 3 2018-09-20 18:27:08 PDT
Comment on attachment 350296 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350296&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1591 > + if (commitState.totalBackdropFilterSize != childCommitState.totalBackdropFilterSize) What happens if you delete this line?
Simon Fraser (smfr)
Comment 4 2018-09-20 19:10:26 PDT
Comment on attachment 350296 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350296&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:95 > +static const unsigned cMaxTotalBackdropFilterSize = 1242 * 2208 * 10; Maybe call this "area" > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:158 > + unsigned totalBackdropFilterSize { 0 }; totalBackdropFilterArea
Dean Jackson
Comment 5 2018-09-20 22:23:30 PDT
Comment on attachment 350296 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350296&action=review >> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1591 >> + if (commitState.totalBackdropFilterSize != childCommitState.totalBackdropFilterSize) > > What happens if you delete this line? This is the best review comment I've ever received.
Dean Jackson
Comment 6 2018-09-20 22:37:17 PDT
Committed r236306: <https://trac.webkit.org/changeset/236306>
Note You need to log in before you can comment on or make changes to this bug.