Bug 189812 - Restrict the total combined size of backdrop filters
Summary: Restrict the total combined size of backdrop filters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-20 18:12 PDT by Dean Jackson
Modified: 2018-09-20 22:37 PDT (History)
4 users (show)

See Also:

Attachments
Patch (27.86 KB, patch)
2018-09-20 18:24 PDT, Dean Jackson 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2018-09-20 18:12:28 PDT 
Restrict the total combined size of backdrop filters
Comment 1 Dean Jackson 2018-09-20 18:12:54 PDT 
<rdar://problem/44532782>
Comment 2 Dean Jackson 2018-09-20 18:24:11 PDT 
Created attachment 350296 [details]
Patch
Comment 3 mitz 2018-09-20 18:27:08 PDT 
Comment on attachment 350296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350296&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1591
> +    if (commitState.totalBackdropFilterSize != childCommitState.totalBackdropFilterSize)

What happens if you delete this line?
Comment 4 Simon Fraser (smfr) 2018-09-20 19:10:26 PDT 
Comment on attachment 350296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350296&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:95
> +static const unsigned cMaxTotalBackdropFilterSize = 1242 * 2208 * 10;

Maybe call this "area"

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:158
> +        unsigned totalBackdropFilterSize { 0 };

totalBackdropFilterArea
Comment 5 Dean Jackson 2018-09-20 22:23:30 PDT 
Comment on attachment 350296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350296&action=review

>> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1591
>> +    if (commitState.totalBackdropFilterSize != childCommitState.totalBackdropFilterSize)
> 
> What happens if you delete this line?

This is the best review comment I've ever received.
Comment 6 Dean Jackson 2018-09-20 22:37:17 PDT 
Committed r236306: <https://trac.webkit.org/changeset/236306>