Bug 189804 - Move IOKitSPI.h from TestRunnerShared to PAL
Summary: Move IOKitSPI.h from TestRunnerShared to PAL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks: 190571 189604
  Show dependency treegraph
 
Reported: 2018-09-20 15:08 PDT by Daniel Bates
Modified: 2018-10-14 22:02 PDT (History)
4 users (show)

See Also:


Attachments
Patch (25.27 KB, patch)
2018-09-20 15:10 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-09-20 15:08:23 PDT
Towards fixing bug #189604 move the IOKit SPI forward declarations to PAL so that they can be shared by code in WebKit, DumpRenderTree and WebKitTestRunner.
Comment 1 Daniel Bates 2018-09-20 15:10:58 PDT
Created attachment 350269 [details]
Patch
Comment 2 Daniel Bates 2018-09-20 15:12:35 PDT
I made one change to IOKitSPI.h when moving it. I removed the "#import <wtf/Platform.h>" statement as this is not needed given our use of prefix headers.
Comment 3 Daniel Bates 2018-09-20 20:15:41 PDT
Comment on attachment 350269 [details]
Patch

Clearing flags on attachment: 350269

Committed r236303: <https://trac.webkit.org/changeset/236303>
Comment 4 Daniel Bates 2018-09-20 20:15:43 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-09-20 20:16:38 PDT
<rdar://problem/44666336>