WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
189804
Move IOKitSPI.h from TestRunnerShared to PAL
https://bugs.webkit.org/show_bug.cgi?id=189804
Summary
Move IOKitSPI.h from TestRunnerShared to PAL
Daniel Bates
Reported
2018-09-20 15:08:23 PDT
Towards fixing
bug #189604
move the IOKit SPI forward declarations to PAL so that they can be shared by code in WebKit, DumpRenderTree and WebKitTestRunner.
Attachments
Patch
(25.27 KB, patch)
2018-09-20 15:10 PDT
,
Daniel Bates
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2018-09-20 15:10:58 PDT
Created
attachment 350269
[details]
Patch
Daniel Bates
Comment 2
2018-09-20 15:12:35 PDT
I made one change to IOKitSPI.h when moving it. I removed the "#import <wtf/Platform.h>" statement as this is not needed given our use of prefix headers.
Daniel Bates
Comment 3
2018-09-20 20:15:41 PDT
Comment on
attachment 350269
[details]
Patch Clearing flags on attachment: 350269 Committed
r236303
: <
https://trac.webkit.org/changeset/236303
>
Daniel Bates
Comment 4
2018-09-20 20:15:43 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5
2018-09-20 20:16:38 PDT
<
rdar://problem/44666336
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug