Bug 189797 - [WPE] Built RPM of WPE webkit fails to install with "nothing provides libWPEToolingBackends.so()"
Summary: [WPE] Built RPM of WPE webkit fails to install with "nothing provides libWPET...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-20 12:31 PDT by Chris King
Modified: 2018-09-21 04:42 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.71 KB, patch)
2018-09-20 23:18 PDT, Adrian Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris King 2018-09-20 12:31:42 PDT
When trying to install from the RPM of WPE built on fedora, I get this error:

Problem: cannot install the best candidate for the job
  - nothing provides libWPEToolingBackends.so()(64bit) needed by wpewebkit-2.21.92-1.fc30.x86_64

It seems like something that shouldn't be needed as a dependency is being listed as one.

Thanks,

Chris
Comment 1 Adrian Perez 2018-09-20 13:00:14 PDT
(In reply to Chris King from comment #0)
> When trying to install from the RPM of WPE built on fedora, I get this error:
> 
> Problem: cannot install the best candidate for the job
>   - nothing provides libWPEToolingBackends.so()(64bit) needed by
> wpewebkit-2.21.92-1.fc30.x86_64
> 
> It seems like something that shouldn't be needed as a dependency is being
> listed as one.

I suppose the Fedora packaging is building _and_ installing the WPE
MiniBrowser. Currently is the only installable component that uses
libWPEToolingBackends.so

Either we tell CMake to install the library when the MiniBrowser is
also installed, or figure out whether it might be possible to link
the library statically in the MiniBrowser. I'll try poke a bit and
see what can be done.
Comment 2 Adrian Perez 2018-09-20 13:33:02 PDT
My impression is that it should be possible to make WPEToolingBackends
a static library. I am going to make a build locally with it turned into
into a static library which gets with PIC enabled (because its contents
will be linked into shared objects afterwards) and make sure nothing
breaks before posting a patch.
Comment 3 Michael Catanzaro 2018-09-20 20:42:01 PDT
(In reply to Adrian Perez from comment #1)
> I suppose the Fedora packaging is building _and_ installing the WPE
> MiniBrowser. Currently is the only installable component that uses
> libWPEToolingBackends.so

Ah good catch, I couldn't figure out where the dependency was coming from.
 
> Either we tell CMake to install the library when the MiniBrowser is
> also installed, or figure out whether it might be possible to link
> the library statically in the MiniBrowser. I'll try poke a bit and
> see what can be done.

Yeah, one or the other. Static would be nicer, since it should be pretty small and won't be used anywhere else.
Comment 4 Adrian Perez 2018-09-20 23:18:30 PDT
Created attachment 350334 [details]
Patch
Comment 5 Adrian Perez 2018-09-20 23:20:23 PDT
(In reply to Michael Catanzaro from comment #3)
> (In reply to Adrian Perez from comment #1)
> > I suppose the Fedora packaging is building _and_ installing the WPE
> > MiniBrowser. Currently is the only installable component that uses
> > libWPEToolingBackends.so
> 
> Ah good catch, I couldn't figure out where the dependency was coming from.
>  
> > Either we tell CMake to install the library when the MiniBrowser is
> > also installed, or figure out whether it might be possible to link
> > the library statically in the MiniBrowser. I'll try poke a bit and
> > see what can be done.
> 
> Yeah, one or the other. Static would be nicer, since it should be pretty
> small and won't be used anywhere else.

Just turning the library into a static one worked perfectly, I've just
tested a build of MiniBrowser and running tests after building with the
change in the attached patch. Let's also try and sneak in this small fix
before releasing 2.22.0 :-)
Comment 6 Adrian Perez 2018-09-20 23:22:00 PDT
By the way, thanks a lot to Chris for reporting this! — I had been
doing my testing with Cog instead of trying to install MiniBrowser
and that's why this went unnoticed until now. Ooops  O:-)
Comment 7 WebKit Commit Bot 2018-09-21 04:42:51 PDT
Comment on attachment 350334 [details]
Patch

Clearing flags on attachment: 350334

Committed r236309: <https://trac.webkit.org/changeset/236309>
Comment 8 WebKit Commit Bot 2018-09-21 04:42:53 PDT
All reviewed patches have been landed.  Closing bug.