Bug 189796 - [WebGL] Use Metal to get the current GPU.
Summary: [WebGL] Use Metal to get the current GPU.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-20 11:08 PDT by Per Arne Vollan
Modified: 2018-09-20 11:31 PDT (History)
5 users (show)

See Also:

Attachments
Patch (12.25 KB, patch)
2018-09-20 11:16 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2018-09-20 11:08:13 PDT 
We currently assume that the first renderer returned by CGLQueryRendererInfo is the current GPU. I believe this is a correct assumption, but it would be safer to use the Metal function CGDirectDisplayCopyCurrentMetalDevice.
Comment 1 Per Arne Vollan 2018-09-20 11:16:04 PDT 
Created attachment 350236 [details]
Patch
Comment 2 EWS Watchlist 2018-09-20 11:19:10 PDT 
Attachment 350236 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:12:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.