Bug 189783 - [Web Animations] Accelerated animations don't get suspended
Summary: [Web Animations] Accelerated animations don't get suspended
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-20 05:01 PDT by Antoine Quint
Modified: 2018-09-21 06:14 PDT (History)
5 users (show)

See Also:


Attachments
Patch (7.34 KB, patch)
2018-09-20 05:08 PDT, Antoine Quint
dino: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.91 MB, application/zip)
2018-09-20 06:24 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews200 for win-future (12.90 MB, application/zip)
2018-09-20 06:45 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.28 MB, application/zip)
2018-09-20 06:55 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-09-20 05:01:12 PDT
<rdar://problem/43033568>
Comment 1 Antoine Quint 2018-09-20 05:08:09 PDT
Created attachment 350187 [details]
Patch
Comment 2 EWS Watchlist 2018-09-20 06:24:43 PDT
Comment on attachment 350187 [details]
Patch

Attachment 350187 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9280433

New failing tests:
animations/suspend-resume-animation-events.html
Comment 3 EWS Watchlist 2018-09-20 06:24:44 PDT
Created attachment 350191 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 4 EWS Watchlist 2018-09-20 06:44:57 PDT
Comment on attachment 350187 [details]
Patch

Attachment 350187 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9280510

New failing tests:
webanimations/accelerated-animation-suspension.html
Comment 5 EWS Watchlist 2018-09-20 06:45:08 PDT
Created attachment 350194 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 6 EWS Watchlist 2018-09-20 06:55:01 PDT
Comment on attachment 350187 [details]
Patch

Attachment 350187 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9280463

New failing tests:
animations/suspend-resume-animation-events.html
Comment 7 EWS Watchlist 2018-09-20 06:55:02 PDT
Created attachment 350196 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 8 Dean Jackson 2018-09-20 09:14:09 PDT
Comment on attachment 350187 [details]
Patch

other tests seem to be failing now though
Comment 9 Antoine Quint 2018-09-21 06:02:17 PDT
The test that regressed was actually marked as flaky in webkit.org/b/189607 and I have a separate patch up for review for this specific issue.
Comment 10 Antoine Quint 2018-09-21 06:09:54 PDT
Committed r236312: <https://trac.webkit.org/changeset/236312>
Comment 11 Antoine Quint 2018-09-21 06:14:34 PDT
Committed r236313: <https://trac.webkit.org/changeset/236313>