Bug 189774 – Adopt safe-area-inset on ImageDocument

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Benjamin Poulain]

Adopt safe-area-instead on ImageDocument

[Benjamin Poulain]

Created attachment 350166 [details]
Patch

[Benjamin Poulain]

<rdar://problem/44624432>

[Benjamin Poulain]

Hopefully I am not too rusty for WebKit patches :)

[Tim Horton]

Comment on attachment 350166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350166&action=review

> Source/WebCore/ChangeLog:8
> +        rdar://problem/44624432

People usually put this up on the line immediately below the bugzilla link. Unless you're being weird on purpose like Beth.

> Source/WebCore/html/ImageDocument.cpp:236
> +        imageElement->setAttribute(styleAttr, "-webkit-user-select:none; display:block; margin:auto; padding:env(safe-area-inset-top) env(safe-area-inset-right) env(safe-area-inset-bottom) env(safe-area-inset-left)");

Trailing semicolons like we had before? Doesn't really matter.

> Source/WebCore/html/ImageDocument.cpp:238
> +        imageElement->setAttribute(styleAttr, "-webkit-user-select:none; padding:env(safe-area-inset-top) env(safe-area-inset-right) env(safe-area-inset-bottom) env(safe-area-inset-left)");

I wish I had added a shorthand for this :P

[Benjamin Poulain]

Created attachment 350261 [details]
Patch

[Benjamin Poulain]

(In reply to Tim Horton from comment #4)
> Comment on attachment 350166 [details]
> Patch
> [...]

Thank you for the quick review Tim!

[WebKit Commit Bot]

Comment on attachment 350261 [details]
Patch

Clearing flags on attachment: 350261

Committed r236290: <https://trac.webkit.org/changeset/236290>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.