Bug 189768 - Add functions to measure memory footprint to JSC
Summary: Add functions to measure memory footprint to JSC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-19 16:24 PDT by Michael Saboff
Modified: 2018-09-21 14:48 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.27 KB, patch)
2018-09-19 16:47 PDT, Michael Saboff
saam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2018-09-19 16:24:02 PDT
This is to provide native JS access to JSC command memory usage data via system call.

<rdar://problem/44612188>
Comment 1 Michael Saboff 2018-09-19 16:47:40 PDT
Created attachment 350159 [details]
Patch
Comment 2 Saam Barati 2018-09-19 17:10:58 PDT
Comment on attachment 350159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350159&action=review

r=me

> Source/JavaScriptCore/jsc.cpp:1204
> +class JSCMemoryFootprint : public JSDestructibleObject {

nit: I think this could inherit from JSNonFinalObject
Comment 3 Michael Saboff 2018-09-19 17:36:54 PDT
(In reply to Saam Barati from comment #2)
> Comment on attachment 350159 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=350159&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/jsc.cpp:1204
> > +class JSCMemoryFootprint : public JSDestructibleObject {
> 
> nit: I think this could inherit from JSNonFinalObject

Change this locally.
Comment 4 Michael Saboff 2018-09-19 17:42:31 PDT
Committed r236235: <https://trac.webkit.org/changeset/236235>
Comment 5 Ryan Haddad 2018-09-20 09:10:40 PDT
Reverted r236235 for reason:

Breaks internal builds.

Committed r236260: <https://trac.webkit.org/changeset/236260>
Comment 6 Ryan Haddad 2018-09-20 09:11:27 PDT
(In reply to Ryan Haddad from comment #5)
> Reverted r236235 for reason:
> 
> Breaks internal builds.
Details are in radar.
Comment 7 Michael Saboff 2018-09-20 16:48:57 PDT
Relanded in r236293: <https://trac.webkit.org/changeset/236293>
Comment 8 Ryan Haddad 2018-09-20 21:37:09 PDT
Rolled out in https://trac.webkit.org/r236305
Comment 9 Michael Saboff 2018-09-21 14:48:40 PDT
Relanded in r2362362: <https://trac.webkit.org/changeset/236362>