Bug 189768 – Add functions to measure memory footprint to JSC

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

This is to provide native JS access to JSC command memory usage data via system call.

<rdar://problem/44612188>

[Michael Saboff]

Created attachment 350159 [details]
Patch

[Saam Barati]

Comment on attachment 350159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350159&action=review

r=me

> Source/JavaScriptCore/jsc.cpp:1204
> +class JSCMemoryFootprint : public JSDestructibleObject {

nit: I think this could inherit from JSNonFinalObject

[Michael Saboff]

(In reply to Saam Barati from comment #2)
> Comment on attachment 350159 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=350159&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/jsc.cpp:1204
> > +class JSCMemoryFootprint : public JSDestructibleObject {
> 
> nit: I think this could inherit from JSNonFinalObject

Change this locally.

[Michael Saboff]

Committed r236235: <https://trac.webkit.org/changeset/236235>

[Ryan Haddad]

Reverted r236235 for reason:

Breaks internal builds.

Committed r236260: <https://trac.webkit.org/changeset/236260>

[Ryan Haddad]

(In reply to Ryan Haddad from comment #5)
> Reverted r236235 for reason:
> 
> Breaks internal builds.
Details are in radar.

[Michael Saboff]

Relanded in r236293: <https://trac.webkit.org/changeset/236293>

[Ryan Haddad]

Rolled out in https://trac.webkit.org/r236305

[Michael Saboff]

Relanded in r2362362: <https://trac.webkit.org/changeset/236362>