Bug 189767 - [WebVTT] Update the parser according to the new region syntax.
Summary: [WebVTT] Update the parser according to the new region syntax.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-19 15:55 PDT by Per Arne Vollan
Modified: 2023-09-08 15:42 PDT (History)
6 users (show)

See Also:


Attachments
Patch (14.02 KB, patch)
2018-09-19 16:27 PDT, Per Arne Vollan
eric.carlson: review+
Details | Formatted Diff | Diff
Patch (14.00 KB, patch)
2018-09-20 08:42 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (14.04 KB, patch)
2018-09-20 09:32 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2018-09-19 15:55:43 PDT
The syntax of WebVTT region declarations has changed. The previous declaration style can be found in https://www.w3.org/2013/07/webvtt.html. The new style is defined in https://w3c.github.io/webvtt/.

Example of the new syntax:

REGION
id=region_floating_point_anchor
regionanchor=41.133%,20.42%
viewportanchor=32.33%,32.44%

This is how this would have been written using the old syntax:

Region: id=region_floating_point_anchor regionanchor=41.133%,20.42% viewportanchor=32.33%,32.44%
Comment 1 Per Arne Vollan 2018-09-19 16:27:56 PDT
Created attachment 350158 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2018-09-19 16:28:33 PDT
<rdar://problem/44621597>
Comment 3 Per Arne Vollan 2018-09-20 08:42:55 PDT
Created attachment 350206 [details]
Patch
Comment 4 Per Arne Vollan 2018-09-20 09:32:32 PDT
Created attachment 350217 [details]
Patch
Comment 5 WebKit Commit Bot 2018-09-20 10:07:11 PDT
Comment on attachment 350217 [details]
Patch

Clearing flags on attachment: 350217

Committed r236265: <https://trac.webkit.org/changeset/236265>
Comment 6 Simon Pieters (:zcorpan) 2018-10-04 08:06:51 PDT
(In reply to Per Arne Vollan from comment #0)
> Example of the new syntax:
> 
> REGION
> id=region_floating_point_anchor
> regionanchor=41.133%,20.42%
> viewportanchor=32.33%,32.44%

The = should be :
Comment 7 Ahmad Saleem 2023-09-08 15:42:22 PDT
Landed: https://github.com/WebKit/WebKit/commit/26669c3d46a0b67d07ab8197299dbce49f16ab47

and didn't seem to back out.

Marking this as 'RESOLVED FIXED'.