When running the jQuery test suite, WebKit (in the form of Safari 3.1.1 on Leopard 10.5.x), fails one of the tests:
64. core module: text(String) (1, 3, 4)
1. Check escaped text
This is either a real failure or an evangelism issue.
* STEPS TO REPRODUCE
1. Launch Safari/WebKit.
2. Open URL: http://jquery.com/test/
3. Wait for test to complete.
WebKit fails 1 of 1157 tests (see SUMMARY for details).
Unknown. Only tested with Safari 3.1.1.
The issue is how document.createTextNode() encodes text.
Created attachment 21052 [details]
Comment on attachment 21052 [details]
This test case is bad.
When the Expected and Actual lines match, the test still fails.
(In reply to comment #0)
> * REGRESSION
> Unknown. Only tested with Safari 3.1.1.
This is a regression as it works with Safari 3.0.4 (523.12.2) on Mac OS X 10.4.11 (8S165).
I also have a fix.
The bisect-builds script with Safari 2.0.4 reports:
Works: r26359 Fails: r26570
Regression occurred in r26474 (noted in comments):
Qt developers: The following test results will likely need to be updated after this bug is fixed:
Note that LayoutTests/fast/xsl/xslt-text-expected.txt is a text dump, while LayoutTests/platform/qt/fast/xsl/xslt-text-expected.txt is a render tree dump. You may be able to use the common test results and remove the Qt-specific results.
Created attachment 21127 [details]
Comment on attachment 21127 [details]
But aside from that entirely-theoretical worry, looks perfect.
Thanks for the heads up David.
Committed revision 33451. Removed unnecessary optimization per Comment #10.
Tor/Simon: Please update Qt test results per Comment #8. Thanks!
*** Bug 18101 has been marked as a duplicate of this bug. ***