Bug 189748 – Garbled rendering of image when applied feConvolveMatrix to it, on Retina display

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

Created attachment 350109 [details]
Video showing bug

Here is test case: https://codepen.io/mark-tyler/pen/VGqbbe
Works fine in Chrome, but Safari (iPhone or OSX), renders totally garbled image.

[Radar WebKit Bug Importer]

<rdar://problem/44621494>

[Simon Fraser (smfr)]

Similar to bug 188486.

[Simon Fraser (smfr)]

Only happens on Retina displays.

[Simon Fraser (smfr)]

diff --git a/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp b/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp
index bea66fbf6bea5a35df7e020b7015ba71e9e00536..674b3aaf8a0fac0381578218df675242a841412e 100644
--- a/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp
+++ b/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp
@@ -391,6 +391,8 @@ void FEConvolveMatrix::platformApplySoftware()
         return;
 
     IntSize paintSize = absolutePaintRect().size();
+    paintSize.scale(filter().filterScale());
+    
     PaintingData paintingData = {
         *srcPixelArray,
         *resultImage,

[Simon Fraser (smfr)]

Created attachment 350574 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 350574 [details]
Patch

Clearing flags on attachment: 350574

Committed r236412: <https://trac.webkit.org/changeset/236412>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

Thanks! any thoughts on when this may be released in Safari on OSX?

[Simon Fraser (smfr)]

(In reply to nitrino from comment #8)
> Thanks! any thoughts on when this may be released in Safari on OSX?

I can't say, but I can tell you that the fix will be in a Safari Tech Preview build in a couple of weeks or so.