Bug 189746 - [XHR] Response MIME type computation should default to text/xml for non-http protocols
Summary: [XHR] Response MIME type computation should default to text/xml for non-http ...
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-19 05:39 PDT by Rob Buis
Modified: 2023-03-27 08:22 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.61 KB, patch)
2018-09-19 05:45 PDT, Rob Buis
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (2.35 MB, application/zip)
2018-09-19 06:53 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.18 MB, application/zip)
2018-09-19 07:11 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews116 for mac-sierra (3.06 MB, application/zip)
2018-09-19 07:42 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (54.01 MB, application/zip)
2018-09-19 07:54 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews206 for win-future (12.84 MB, application/zip)
2018-09-19 09:43 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (47.78 MB, application/zip)
2018-09-19 09:56 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2018-09-19 05:39:59 PDT
See steps in https://xhr.spec.whatwg.org/#response-mime-type
Comment 1 Rob Buis 2018-09-19 05:45:23 PDT
Created attachment 350105 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2018-09-19 06:02:48 PDT
Comment on attachment 350105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350105&action=review

> Source/WebCore/ChangeLog:3
> +        [XHR] Response MIME type computation should return text/xml for non-http protocols

IIUC, "should default to text/xml" is more accurate.

> LayoutTests/ChangeLog:9
> +        * fast/files/xhr-response-blob.html:

Do we also have upstream WPT tests we can import/update/write for this?
Comment 3 Rob Buis 2018-09-19 06:35:42 PDT
Comment on attachment 350105 [details]
Patch

Clearing the review flag as this needs more investigation. Also probably needs a similar chromium change.
Comment 4 EWS Watchlist 2018-09-19 06:52:59 PDT
Comment on attachment 350105 [details]
Patch

Attachment 350105 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9269156

New failing tests:
fast/xmlhttprequest/xmlhttprequest-responseXML-html-no-responsetype.html
fast/xmlhttprequest/xmlhttprequest-responseXML-html-document-responsetype-strict.html
fast/events/event-handler-detached-document.html
fast/xmlhttprequest/xmlhttprequest-responseXML-html-document-responsetype-quirks.html
fast/dom/Document/adoptNode-quirks-mismatch.html
fast/dom/Document/adoptNode-quirks-mismatch2.html
svg/load-event-detached.html
Comment 5 EWS Watchlist 2018-09-19 06:53:01 PDT
Created attachment 350110 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 6 EWS Watchlist 2018-09-19 07:11:45 PDT
Comment on attachment 350105 [details]
Patch

Attachment 350105 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9269176

New failing tests:
fast/xmlhttprequest/xmlhttprequest-responseXML-html-no-responsetype.html
fast/xmlhttprequest/xmlhttprequest-responseXML-html-document-responsetype-strict.html
fast/events/event-handler-detached-document.html
fast/xmlhttprequest/xmlhttprequest-responseXML-html-document-responsetype-quirks.html
fast/dom/Document/adoptNode-quirks-mismatch.html
fast/dom/Document/adoptNode-quirks-mismatch2.html
svg/load-event-detached.html
Comment 7 EWS Watchlist 2018-09-19 07:11:47 PDT
Created attachment 350111 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 8 EWS Watchlist 2018-09-19 07:42:55 PDT
Comment on attachment 350105 [details]
Patch

Attachment 350105 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9269252

New failing tests:
fast/xmlhttprequest/xmlhttprequest-responseXML-html-no-responsetype.html
fast/xmlhttprequest/xmlhttprequest-responseXML-html-document-responsetype-strict.html
fast/events/event-handler-detached-document.html
fast/xmlhttprequest/xmlhttprequest-responseXML-html-document-responsetype-quirks.html
fast/dom/Document/adoptNode-quirks-mismatch.html
fast/dom/Document/adoptNode-quirks-mismatch2.html
svg/load-event-detached.html
Comment 9 EWS Watchlist 2018-09-19 07:42:57 PDT
Created attachment 350113 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 10 EWS Watchlist 2018-09-19 07:54:51 PDT
Comment on attachment 350105 [details]
Patch

Attachment 350105 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9269248

New failing tests:
fast/xmlhttprequest/xmlhttprequest-responseXML-html-no-responsetype.html
fast/xmlhttprequest/xmlhttprequest-responseXML-html-document-responsetype-strict.html
fast/events/event-handler-detached-document.html
fast/xmlhttprequest/xmlhttprequest-responseXML-html-document-responsetype-quirks.html
fast/dom/Document/adoptNode-quirks-mismatch.html
fast/dom/Document/adoptNode-quirks-mismatch2.html
svg/load-event-detached.html
Comment 11 EWS Watchlist 2018-09-19 07:54:54 PDT
Created attachment 350117 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 12 EWS Watchlist 2018-09-19 09:42:56 PDT
Comment on attachment 350105 [details]
Patch

Attachment 350105 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9270640

New failing tests:
fast/xmlhttprequest/xmlhttprequest-responseXML-html-no-responsetype.html
fast/xmlhttprequest/xmlhttprequest-responseXML-html-document-responsetype-strict.html
fast/events/event-handler-detached-document.html
fast/xmlhttprequest/xmlhttprequest-responseXML-html-document-responsetype-quirks.html
fast/dom/Document/adoptNode-quirks-mismatch.html
fast/dom/Document/adoptNode-quirks-mismatch2.html
svg/load-event-detached.html
Comment 13 EWS Watchlist 2018-09-19 09:43:07 PDT
Created attachment 350125 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 14 EWS Watchlist 2018-09-19 09:56:16 PDT
Comment on attachment 350105 [details]
Patch

Attachment 350105 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9270407

New failing tests:
fast/xmlhttprequest/xmlhttprequest-responseXML-html-no-responsetype.html
fast/xmlhttprequest/xmlhttprequest-responseXML-html-document-responsetype-strict.html
fast/events/event-handler-detached-document.html
fast/xmlhttprequest/xmlhttprequest-responseXML-html-document-responsetype-quirks.html
fast/dom/Document/adoptNode-quirks-mismatch.html
fast/dom/Document/adoptNode-quirks-mismatch2.html
svg/load-event-detached.html
Comment 15 EWS Watchlist 2018-09-19 09:56:19 PDT
Created attachment 350128 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 16 Anne van Kesteren 2023-03-27 08:22:03 PDT
It looks like this has been improved.