Bug 189721 – Crash under WebProcessProxy::suspendedPageWasDestroyed(WebKit::SuspendedPageProxy&)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Crash under WebProcessProxy::suspendedPageWasDestroyed(WebKit::SuspendedPageProxy&):
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.WebKit              	0x0000000105c6e11f WTF::KeyValuePair<unsigned long long, WebKit::SuspendedPageProxy*>* WTF::HashTable<unsigned long long, WTF::KeyValuePair<unsigned long long, WebKit::SuspendedPageProxy*>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WebKit::SuspendedPageProxy*> >, WTF::IntHash<unsigned long long>, WTF::HashMap<unsigned long long, WebKit::SuspendedPageProxy*, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WebKit::SuspendedPageProxy*> >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> >::lookup<WTF::IdentityHashTranslator<WTF::HashMap<unsigned long long, WebKit::SuspendedPageProxy*, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WebKit::SuspendedPageProxy*> >::KeyValuePairTraits, WTF::IntHash<unsigned long long> >, unsigned long long>(unsigned long long const&) + 117
1   com.apple.WebKit              	0x0000000105c6e085 WTF::HashTableIterator<unsigned long long, WTF::KeyValuePair<unsigned long long, WebKit::SuspendedPageProxy*>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WebKit::SuspendedPageProxy*> >, WTF::IntHash<unsigned long long>, WTF::HashMap<unsigned long long, WebKit::SuspendedPageProxy*, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WebKit::SuspendedPageProxy*> >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> > WTF::HashTable<unsigned long long, WTF::KeyValuePair<unsigned long long, WebKit::SuspendedPageProxy*>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WebKit::SuspendedPageProxy*> >, WTF::IntHash<unsigned long long>, WTF::HashMap<unsigned long long, WebKit::SuspendedPageProxy*, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WebKit::SuspendedPageProxy*> >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> >::find<WTF::IdentityHashTranslator<WTF::HashMap<unsigned long long, WebKit::SuspendedPageProxy*, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WebKit::SuspendedPageProxy*> >::KeyValuePairTraits, WTF::IntHash<unsigned long long> >, unsigned long long>(unsigned long long const&) + 23
2   com.apple.WebKit              	0x0000000105c684e2 WTF::HashMap<unsigned long long, WebKit::SuspendedPageProxy*, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WebKit::SuspendedPageProxy*> >::remove(unsigned long long const&) + 14
3   com.apple.WebKit              	0x0000000105c684c5 WebKit::WebProcessProxy::suspendedPageWasDestroyed(WebKit::SuspendedPageProxy&) + 39
4   com.apple.WebKit              	0x0000000105aee6c8 WebKit::SuspendedPageProxy::~SuspendedPageProxy() + 44
5   com.apple.WebKit              	0x0000000105aee776 WebKit::SuspendedPageProxy::~SuspendedPageProxy() + 14
6   com.apple.WebKit              	0x00000001059312de WebKit::WebPageProxy::~WebPageProxy() + 222
7   com.apple.WebKit              	0x0000000105ceeb7f -[WKObject dealloc] + 25
8   com.apple.WebKit              	0x0000000105cca316 WebKit::WebViewImpl::~WebViewImpl() + 1082
9   com.apple.WebKit              	0x0000000105930f3a -[WKView dealloc] + 116
10  com.apple.Safari.framework    	0x000000010348e94b -[BrowserWKView dealloc] + 105
11  libobjc.A.dylib               	0x00007fff5c4d2c8c (anonymous namespace)::AutoreleasePoolPage::pop(void*) + 726
12  com.apple.CoreFoundation      	0x00007fff305a8e76 _CFAutoreleasePoolPop + 22
13  com.apple.AppKit              	0x00007fff2de06e6a _wrapRunLoopWithAutoreleasePoolHandler + 85
14  com.apple.CoreFoundation      	0x00007fff3063495d __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 23
15  com.apple.CoreFoundation      	0x00007fff30634892 __CFRunLoopDoObservers + 452
16  com.apple.CoreFoundation      	0x00007fff305d5d20 CFRunLoopRunSpecific + 523
17  com.apple.HIToolbox           	0x00007fff2f86f895 RunCurrentEventLoopInMode + 293
18  com.apple.HIToolbox           	0x00007fff2f86f5cb ReceiveNextEventCommon + 618
19  com.apple.HIToolbox           	0x00007fff2f86f348 _BlockUntilNextEventMatchingListInModeWithFilter + 64
20  com.apple.AppKit              	0x00007fff2db2c8df _DPSNextEvent + 997
21  com.apple.AppKit              	0x00007fff2db2b67e -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1362
22  com.apple.Safari.framework    	0x000000010338a87d -[BrowserApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 273
23  com.apple.AppKit              	0x00007fff2db256e1 -[NSApplication run] + 699
24  com.apple.AppKit              	0x00007fff2db14e1b NSApplicationMain + 780
25  libdyld.dylib                 	0x00007fff5d5ab0a1 start + 1

[Chris Dumez]

<rdar://problem/44359788>

[Chris Dumez]

Created attachment 350070 [details]
Patch

[Chris Dumez]

Comment on attachment 350070 [details]
Patch

I think I have a test.

[Chris Dumez]

Created attachment 350072 [details]
Patch

[Chris Dumez]

ping review?

[Geoffrey Garen]

Comment on attachment 350072 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 350072 [details]
Patch

Clearing flags on attachment: 350072

Committed r236226: <https://trac.webkit.org/changeset/236226>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

This change appears to have caused TestWebKitAPI.ServiceWorkers.RestoreFromDiskNonDefaultStore to crash:

https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20%28Tests%29/builds/8049

[Ryan Haddad]

Created attachment 350202 [details]
ServiceWorkers.RestoreFromDiskNonDefaultStore crashlog

[Chris Dumez]

(In reply to Ryan Haddad from comment #10)
> Created attachment 350202 [details]
> ServiceWorkers.RestoreFromDiskNonDefaultStore crashlog

Looking now, thank you.

[Chris Dumez]

(In reply to Chris Dumez from comment #11)
> (In reply to Ryan Haddad from comment #10)
> > Created attachment 350202 [details]
> > ServiceWorkers.RestoreFromDiskNonDefaultStore crashlog
> 
> Looking now, thank you.

Fixed in <https://trac.webkit.org/changeset/236262>.