Bug 189720 - REGRESSION (r236006): New waitingForKey() requirement breaks Modern EME tests.
Summary: REGRESSION (r236006): New waitingForKey() requirement breaks Modern EME tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on: 189616
Blocks:
  Show dependency tree / graph
 
Reported: 2018-09-18 15:39 PDT by Jer Noble
Modified: 2018-09-19 06:58 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.80 KB, patch)
2018-09-18 15:41 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-09-18 15:39:50 PDT 
REGRESSION (r236006): New waitingForKey() requirement breaks Modern EME tests.
Comment 1 Jer Noble 2018-09-18 15:40:21 PDT 
<rdar://problem/44572140>
Comment 2 Jer Noble 2018-09-18 15:41:41 PDT 
Created attachment 350069 [details]
Patch
Comment 3 Xabier Rodríguez Calvar 2018-09-18 23:55:08 PDT 
Comment on attachment 350069 [details]
Patch

Reading your analysis of bug 189616, this will fix your regression if you consider that you're waiting for a key just when you fire the initialization data and will allow to not bail out in step 2 of https://www.w3.org/TR/encrypted-media/#resume-playback .

rs=me
Comment 4 WebKit Commit Bot 2018-09-19 06:58:34 PDT 
Comment on attachment 350069 [details]
Patch

Clearing flags on attachment: 350069

Committed r236204: <https://trac.webkit.org/changeset/236204>
Comment 5 WebKit Commit Bot 2018-09-19 06:58:36 PDT 
All reviewed patches have been landed.  Closing bug.