RESOLVED FIXED 189719
Simply authentication code even more! 
https://bugs.webkit.org/show_bug.cgi?id=189719
Summary Simply authentication code even more!
Alex Christensen
Reported 2018-09-18 15:30:07 PDT
Simply authentication code even more!
Attachments
Patch (31.22 KB, patch)
2018-09-18 15:31 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (31.71 KB, patch)
2018-09-18 15:39 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (43.13 KB, patch)
2018-09-19 13:42 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (44.31 KB, patch)
2018-09-21 11:57 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-09-18 15:31:57 PDT
Created attachment 350066 [details] Patch
EWS Watchlist
Comment 2 2018-09-18 15:34:27 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Alex Christensen
Comment 3 2018-09-18 15:39:24 PDT
Created attachment 350068 [details] Patch
Alex Christensen
Comment 4 2018-09-19 13:42:06 PDT
Created attachment 350148 [details] Patch
Andy Estes
Comment 5 2018-09-21 11:18:19 PDT
Comment on attachment 350148 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350148&action=review r=me, but toAuthenticationChallengeDisposition has a bug you need to fix. > Source/WebKit/Shared/Authentication/AuthenticationChallengeDisposition.h:49 > + WebKit::AuthenticationChallengeDisposition, > + WebKit::AuthenticationChallengeDisposition::UseCredential, > + WebKit::AuthenticationChallengeDisposition::PerformDefaultHandling, > + WebKit::AuthenticationChallengeDisposition::Cancel, > + WebKit::AuthenticationChallengeDisposition::RejectProtectionSpaceAndContinue Needs more indentation. > Source/WebKit/UIProcess/API/C/WKPage.cpp:2153 > - return authenticationChallenge.listener().rejectProtectionSpaceAndContinue(); > + return authenticationChallenge.listener().completeChallenge(WebKit::AuthenticationChallengeDisposition::RejectProtectionSpaceAndContinue); Ditto. > Source/WebKit/UIProcess/Cocoa/NavigationState.mm:861 > + case NSURLSessionAuthChallengeCancelAuthenticationChallenge: > + return AuthenticationChallengeDisposition::UseCredential; Shouldn't this map to AuthenticationChallengeDisposition::Cancel?
Alex Christensen
Comment 6 2018-09-21 11:57:40 PDT
Created attachment 350398 [details] Patch
Alex Christensen
Comment 7 2018-09-21 12:25:39 PDT
Comment on attachment 350398 [details] Patch http://trac.webkit.org/r236344
Radar WebKit Bug Importer
Comment 8 2018-09-21 12:26:25 PDT
<rdar://problem/44688771>
Note You need to log in before you can comment on or make changes to this bug.