Bug 189695 - REGRESSION (PSON): White or Black flash occurs when process swapping on navigation on iOS
Summary: REGRESSION (PSON): White or Black flash occurs when process swapping on navig...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-18 01:56 PDT by Antti Koivisto
Modified: 2018-09-26 05:06 PDT (History)
7 users (show)

See Also:


Attachments
patch (18.80 KB, patch)
2018-09-25 05:14 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (19.03 KB, patch)
2018-09-25 06:31 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (19.05 KB, patch)
2018-09-25 06:47 PDT, Antti Koivisto
simon.fraser: review+
simon.fraser: commit-queue-
Details | Formatted Diff | Diff
patch (20.10 KB, patch)
2018-09-26 04:28 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2018-09-18 01:56:10 PDT
Fix it on iOS too.
Comment 1 Antti Koivisto 2018-09-18 01:56:26 PDT
<rdar://problem/44551146>
Comment 2 Antti Koivisto 2018-09-25 05:14:19 PDT
Created attachment 350747 [details]
patch
Comment 3 Antti Koivisto 2018-09-25 06:31:31 PDT
Created attachment 350749 [details]
patch
Comment 4 EWS Watchlist 2018-09-25 06:32:49 PDT
Attachment 350749 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:42:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Antti Koivisto 2018-09-25 06:47:47 PDT
Created attachment 350750 [details]
patch
Comment 6 Simon Fraser (smfr) 2018-09-25 10:52:29 PDT
Comment on attachment 350750 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350750&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1704
> +    [self _processWillChange];

It's weird that "process did exit" calls "process will change". _processWillChange implies we're still attached to the old process but are about to switch.

> Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:165
> +    if (!m_drawingArea)
> +        return;

Blank line after the return please.

> Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:185
> +    if (!m_drawingArea)
> +        return;

Blank line after the return please.

> Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:216
> +    [m_contentView _processDidExit];
> +    [m_webView _processWillSwap];

Please keep the contentView and webView methods the same.
Comment 7 Antti Koivisto 2018-09-26 04:28:38 PDT
Created attachment 350855 [details]
patch
Comment 8 WebKit Commit Bot 2018-09-26 05:06:19 PDT
Comment on attachment 350855 [details]
patch

Clearing flags on attachment: 350855

Committed r236500: <https://trac.webkit.org/changeset/236500>
Comment 9 WebKit Commit Bot 2018-09-26 05:06:20 PDT
All reviewed patches have been landed.  Closing bug.