Fix it on iOS too.
<rdar://problem/44551146>
Created attachment 350747 [details] patch
Created attachment 350749 [details] patch
Attachment 350749 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:42: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 350750 [details] patch
Comment on attachment 350750 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=350750&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1704 > + [self _processWillChange]; It's weird that "process did exit" calls "process will change". _processWillChange implies we're still attached to the old process but are about to switch. > Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:165 > + if (!m_drawingArea) > + return; Blank line after the return please. > Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:185 > + if (!m_drawingArea) > + return; Blank line after the return please. > Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:216 > + [m_contentView _processDidExit]; > + [m_webView _processWillSwap]; Please keep the contentView and webView methods the same.
Created attachment 350855 [details] patch
Comment on attachment 350855 [details] patch Clearing flags on attachment: 350855 Committed r236500: <https://trac.webkit.org/changeset/236500>
All reviewed patches have been landed. Closing bug.