Bug 189656 - Add more Fullscreen logging
Summary: Add more Fullscreen logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-16 17:43 PDT by Simon Fraser (smfr)
Modified: 2018-09-17 15:16 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.56 KB, patch)
2018-09-16 17:44 PDT, Simon Fraser (smfr) 		jer.noble: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-09-16 17:43:28 PDT 
Add more Fullscreen logging
Comment 1 Simon Fraser (smfr) 2018-09-16 17:44:13 PDT 
Created attachment 349874 [details]
Patch
Comment 2 EWS Watchlist 2018-09-16 17:47:26 PDT 
Attachment 349874 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jer Noble 2018-09-17 09:58:38 PDT 
Comment on attachment 349874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349874&action=review

> Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm:53
> +    LOG(Fullscreen, "VideoFullscreenModelVideoElement %p ctor", this);

For the model logging, you may want to consider using the runtime logging macros. (We can't currently do runtime logging for the Manager classes; they require a single Document to configure the logging.)
Comment 4 Simon Fraser (smfr) 2018-09-17 15:15:09 PDT 
https://trac.webkit.org/r236088
Comment 5 Radar WebKit Bug Importer 2018-09-17 15:16:19 PDT 
<rdar://problem/44536420>