Bug 189638 - Web Inspector: Source View doesn't scroll to show line when breakpoint is hit inside of <script> in HTML resource
Summary: Web Inspector: Source View doesn't scroll to show line when breakpoint is hit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-14 16:50 PDT by Joseph Pecoraro
Modified: 2018-09-14 17:40 PDT (History)
6 users (show)

See Also:


Attachments
[TEST PAGE] test.html (1.79 KB, text/html)
2018-09-14 16:50 PDT, Joseph Pecoraro
no flags Details
[PATCH] Proposed Fix (4.71 KB, patch)
2018-09-14 16:55 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2018-09-14 16:50:29 PDT
Created attachment 349829 [details]
[TEST PAGE] test.html

Source View doesn't scroll to show line when breakpoint is hit inside of <script> in HTML resource

Steps to Reproduce:
1. Open test page
2. Set a breakpoint on line test.html:100
3. Reload the page
  => Triggers breakpoint, should scroll to show line 100, but doesn't appear to

Notes:
• Works if this was test.js script resource, but does not work in test.html document resource pausing on page load
• The test.html TextEditor content loads multiple times (inline script content, then full resource content). The act of re-setting the TextEditor content string with full content wipes out the revealed position.
Comment 1 Joseph Pecoraro 2018-09-14 16:50:49 PDT
<rdar://problem/43359278>
Comment 2 Joseph Pecoraro 2018-09-14 16:55:01 PDT
Created attachment 349830 [details]
[PATCH] Proposed Fix
Comment 3 Matt Baker 2018-09-14 17:14:38 PDT
Comment on attachment 349830 [details]
[PATCH] Proposed Fix

r=me, works as advertised!
Comment 4 WebKit Commit Bot 2018-09-14 17:40:09 PDT
Comment on attachment 349830 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 349830

Committed r236028: <https://trac.webkit.org/changeset/236028>
Comment 5 WebKit Commit Bot 2018-09-14 17:40:10 PDT
All reviewed patches have been landed.  Closing bug.