Bug 189637 - The BytecodeGenerator should not waste time calling emitDebugHook() when the debugger is off.
Summary: The BytecodeGenerator should not waste time calling emitDebugHook() when the ...
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-14 16:48 PDT by Mark Lam
Modified: 2018-09-17 14:57 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch. (30.04 KB, patch)
2018-09-17 13:11 PDT, Mark Lam 		ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
x86_64 benchmark results. (96.59 KB, text/plain)
2018-09-17 13:17 PDT, Mark Lam 		no flags Details
Archive of layout-test-results from ews117 for mac-sierra (3.64 MB, application/zip)
2018-09-17 14:57 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-09-14 16:48:29 PDT 
emitDebugHook() will always check BytecodeGenerator::m_shouldEmitDebugHooks and return early anyway.  We can cut this code path off earlier, and save a bunch of calls.
Comment 1 Radar WebKit Bug Importer 2018-09-14 16:48:59 PDT 
<rdar://problem/44473828>
Comment 2 Mark Lam 2018-09-17 13:11:31 PDT 
Created attachment 349926 [details]
proposed patch.

Perf appears to be neutral.  Let's get some EWS testing.
Comment 3 Mark Lam 2018-09-17 13:17:58 PDT 
Created attachment 349929 [details]
x86_64 benchmark results.
Comment 4 EWS Watchlist 2018-09-17 14:57:11 PDT 
Comment on attachment 349926 [details]
proposed patch.

Attachment 349926 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9247414

Number of test failures exceeded the failure limit.
Comment 5 EWS Watchlist 2018-09-17 14:57:13 PDT 
Created attachment 349945 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6