Bug 189631 - Refactoring related to Safe Browsing
Summary: Refactoring related to Safe Browsing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-14 14:15 PDT by Alex Christensen
Modified: 2018-09-17 10:09 PDT (History)
7 users (show)

See Also:

Attachments
Patch (17.49 KB, patch)
2018-09-14 14:20 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (17.57 KB, patch)
2018-09-14 14:29 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (17.51 KB, patch)
2018-09-17 09:32 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-09-14 14:15:02 PDT 
Refactoring related to Safe Browsing
Comment 1 Alex Christensen 2018-09-14 14:20:24 PDT 
Created attachment 349803 [details]
Patch
Comment 2 Alex Christensen 2018-09-14 14:29:37 PDT 
Created attachment 349807 [details]
Patch
Comment 3 WebKit Commit Bot 2018-09-14 15:09:39 PDT 
Comment on attachment 349807 [details]
Patch

Clearing flags on attachment: 349807

Committed r236020: <https://trac.webkit.org/changeset/236020>
Comment 4 WebKit Commit Bot 2018-09-14 15:09:41 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-09-14 15:10:23 PDT 
<rdar://problem/44470854>
Comment 6 Dawei Fenton (:realdawei) 2018-09-14 16:10:23 PDT 
(In reply to WebKit Commit Bot from comment #3)
> Comment on attachment 349807 [details]
> Patch
> 
> Clearing flags on attachment: 349807
> 
> Committed r236020: <https://trac.webkit.org/changeset/236020>


Seeing an API test failure on High Sierra WK1 after this revision:

sample output:
https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20%28Tests%29/builds/7991/steps/run-api-tests/logs/stdio

  TestWebKitAPI.WKNavigation.NavigationActionHasNavigation
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:236
        Value of: !!navigationAction._mainFrameNavigation
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:237
        Expected equality of these values:
          navigationAction._mainFrameNavigation
            Which is: NULL
          navigation
            Which is: 0x7f8421c36260
Comment 7 Matt Lewis 2018-09-14 18:20:34 PDT 
Reverted r236020 for reason:

This caused an api failure on High Sierra

Committed r236030: <https://trac.webkit.org/changeset/236030>
Comment 8 Alex Christensen 2018-09-17 09:32:17 PDT 
Created attachment 349892 [details]
Patch
Comment 9 WebKit Commit Bot 2018-09-17 10:09:54 PDT 
Comment on attachment 349892 [details]
Patch

Clearing flags on attachment: 349892

Committed r236067: <https://trac.webkit.org/changeset/236067>
Comment 10 WebKit Commit Bot 2018-09-17 10:09:56 PDT 
All reviewed patches have been landed.  Closing bug.