Bug 189614 - Remove unused code in WebKitLegacy
Summary: Remove unused code in WebKitLegacy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-14 00:33 PDT by Tim Horton
Modified: 2019-03-01 13:59 PST (History)
7 users (show)

See Also:

Attachments
Patch (162.86 KB, patch)
2018-09-14 00:34 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (160.38 KB, patch)
2019-03-01 13:29 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-09-14 00:33:46 PDT 
Remove unused code in WebKitLegacy
Comment 1 Tim Horton 2018-09-14 00:34:50 PDT 
Created attachment 349744 [details]
Patch
Comment 2 Tim Horton 2018-09-14 00:35:14 PDT 
Ccing some folks to tell me why we can't.
Comment 3 Tim Horton 2018-09-14 00:35:45 PDT 
It's also somewhat possible we have to keep stub headers around, will try to see if that's the case.
Comment 4 Tim Horton 2018-09-14 02:10:12 PDT 
Comment on attachment 349744 [details]
Patch

Actually, I know why. Will return to this in the not too distant future.
Comment 5 Anders Carlsson 2019-02-28 18:05:26 PST 
😮
Comment 6 Tim Horton 2019-03-01 00:14:04 PST 
A cursory glance at the internet suggests that there are many people who do import these two public headers directly, so perhaps we do need to leave them behind (and empty)?
Comment 7 Anders Carlsson 2019-03-01 13:14:01 PST 
(In reply to Tim Horton from comment #6)
> A cursory glance at the internet suggests that there are many people who do
> import these two public headers directly, so perhaps we do need to leave
> them behind (and empty)?

I think (and Dan agrees) that you can go ahead and remove them. It's not unusual for people to have to fix their project builds when moving to a newer SDK.
Comment 8 Tim Horton 2019-03-01 13:27:22 PST 
Perfect.
Comment 9 Tim Horton 2019-03-01 13:29:35 PST 
Created attachment 363366 [details]
Patch
Comment 10 WebKit Commit Bot 2019-03-01 13:58:52 PST 
Comment on attachment 363366 [details]
Patch

Clearing flags on attachment: 363366

Committed r242287: <https://trac.webkit.org/changeset/242287>
Comment 11 WebKit Commit Bot 2019-03-01 13:58:53 PST 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2019-03-01 13:59:53 PST 
<rdar://problem/48521996>