Bug 189610 - WebGL 2 conformance: rgb-format-support.html
Summary: WebGL 2 conformance: rgb-format-support.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Fan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-13 19:15 PDT by Justin Fan
Modified: 2018-09-14 17:05 PDT (History)
11 users (show)

See Also:

Attachments
Patch (19.27 KB, patch)
2018-09-13 19:29 PDT, Justin Fan 		no flags Details | Formatted Diff | Diff
Patch (19.31 KB, patch)
2018-09-13 19:33 PDT, Justin Fan 		no flags Details | Formatted Diff | Diff
Patch (19.29 KB, patch)
2018-09-14 15:05 PDT, Justin Fan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Fan 2018-09-13 19:15:28 PDT 
WebGL 2 conformance: rbg-format-support.html
Comment 1 Justin Fan 2018-09-13 19:16:03 PDT 
<rdar://problem/44403343>
Comment 2 Justin Fan 2018-09-13 19:29:45 PDT 
Created attachment 349726 [details]
Patch
Comment 3 Justin Fan 2018-09-13 19:33:34 PDT 
Created attachment 349727 [details]
Patch
Comment 4 Dean Jackson 2018-09-14 11:18:24 PDT 
Comment on attachment 349727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349727&action=review

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:380
> +    // On macOS (OpenGL 4.1) we must emulate GL ES 3/OpenGL 4.2 glGetInternalformativ.

This path might not be just macOS, so just say "On desktop OpenGL"

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:396
> +    // FIXME: The way I understand this is that this will return a MINIMUM numSamples for all accepeted internalformats.
> +    // However, the true value of this on supported GL versions is gleaned via a getInternalformativ call that depends on internalformat.

This isn't really a FIXME.
Comment 5 Justin Fan 2018-09-14 15:05:19 PDT 
Created attachment 349813 [details]
Patch
Comment 6 WebKit Commit Bot 2018-09-14 17:05:30 PDT 
Comment on attachment 349813 [details]
Patch

Clearing flags on attachment: 349813

Committed r236025: <https://trac.webkit.org/changeset/236025>
Comment 7 WebKit Commit Bot 2018-09-14 17:05:32 PDT 
All reviewed patches have been landed.  Closing bug.