Bug 189603 – Web Inspector: Timelines: clicking a row in Script > Events grid triggers Location popover when column is hidden

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

Summary:
Clicking a row in Script > Events grid triggers Location popover when column is hidden. The Layout timeline view has the same issue.

Test Page:
<script>
    console.profile("Test");
    console.profileEnd("Test");
</script>

Steps to Reproduce:
1. Inspect test page > Timelines
2. Reload page to record a timeline
3. Select JavaScript & Events timeline > Events
4. Hide Location column
5. Click the row '"Test" Profile Recorded'
  => Popover with location stack trace appears

[Radar WebKit Bug Importer]

<rdar://problem/44431403>

[Matt Baker]

Created attachment 349704 [details]
Patch

[Matt Baker]

Comment on attachment 349704 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349704&action=review

> Source/WebInspectorUI/UserInterface/Views/DataGrid.js:897
> +    isColumnVisible(columnIdentifier)

This class is old and mixes its public/private members, so I chose not to move this method after making it public.

> Source/WebInspectorUI/UserInterface/Views/LayoutTimelineDataGrid.js:38
> +    }

An alternative approach would be to eliminate these subclasses, and instead specify the call frames column in TimelineDataGrid's constructor. I chose not too, since all of this code is old and didn't want to rock the boat.

[Joseph Pecoraro]

Comment on attachment 349704 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 349704 [details]
Patch

Clearing flags on attachment: 349704

Committed r235997: <https://trac.webkit.org/changeset/235997>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.