Bug 189577 - Remove a MSVC workaround in InspectorStyle::styleWithProperties
Summary: Remove a MSVC workaround in InspectorStyle::styleWithProperties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-13 00:51 PDT by Fujii Hironori
Modified: 2018-09-13 10:30 PDT (History)
9 users (show)

See Also:


Attachments
Patch (2.05 KB, patch)
2018-09-13 00:56 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.58 MB, application/zip)
2018-09-13 04:18 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2018-09-13 00:51:51 PDT
Remove a MSVC workaround in InspectorStyle::styleWithProperties

It is introduced in Bug 131596 Comment 11.

>         // Visual Studio disagrees with other compilers as to whether 'class' is needed here.
> #if COMPILER(MSVC)
>         enum class Protocol::CSS::CSSPropertyStatus status;
> #else
>         enum Inspector::Protocol::CSS::CSSPropertyStatus status;
> #endif
Comment 1 Fujii Hironori 2018-09-13 00:56:58 PDT
Created attachment 349641 [details]
Patch
Comment 2 EWS Watchlist 2018-09-13 04:18:37 PDT
Comment on attachment 349641 [details]
Patch

Attachment 349641 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9201461

New failing tests:
fast/animation/css-animation-resuming-when-visible-with-style-change2.html
Comment 3 EWS Watchlist 2018-09-13 04:18:39 PDT
Created attachment 349653 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 4 WebKit Commit Bot 2018-09-13 10:16:12 PDT
Comment on attachment 349641 [details]
Patch

Clearing flags on attachment: 349641

Committed r235977: <https://trac.webkit.org/changeset/235977>
Comment 5 WebKit Commit Bot 2018-09-13 10:16:14 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-09-13 10:17:29 PDT
<rdar://problem/44422014>
Comment 7 Joseph Pecoraro 2018-09-13 10:30:16 PDT
Nice!