Bug 189574 – Move JavaScriptCore files to match Xcode project hierarchy

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[David Kilzer (:ddkilzer)]

Move JavaScriptCore files to match Xcode project hierarchy.

These changes will let us turn "virtual" folders into folders that are backed by a directory in the project.

The changes can be summarized as follows:

Source/JavaScriptCore/runtime/JSAPIValueWrapper.cpp => Source/JavaScriptCore/API/JSAPIValueWrapper.cpp
Source/JavaScriptCore/runtime/JSAPIValueWrapper.h => Source/JavaScriptCore/API/JSAPIValueWrapper.h
Source/JavaScriptCore/Scripts/generateYarrUnicodePropertyTables.py => Source/JavaScriptCore/yarr/generateYarrUnicodePropertyTables.py
Source/JavaScriptCore/Scripts/hasher.py => Source/JavaScriptCore/yarr/hasher.py

Fallout from the changes includes:
- Updating the Xcode project file to point to the new locations.
- Adding hasher.py (previously omitted) to the Xcode project file.
- Updating CMakeLists.txt, DerivedSources.make and Sources.txt for new locations.
- Updating Source/JavaScriptCore/runtime/JSImmutableButterfly.h and Source/JavaScriptCore/runtime/RuntimeType.h to build within regenerated UnifiedSources (missing headers that were previously included in JSAPIValueWrapper.{cpp,h}).

[David Kilzer (:ddkilzer)]

NOTE: All moved files are 100% the same after the move.

[David Kilzer (:ddkilzer)]

Created attachment 349623 [details]
Patch v1

[David Kilzer (:ddkilzer)]

Created attachment 349624 [details]
Patch v2

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #2)
> Created attachment 349623 [details]
> Patch v1

Oops, this included a minor clean-up that I'm going to commit separately.

[David Kilzer (:ddkilzer)]

Comment on attachment 349624 [details]
Patch v2

Sigh, looks like this will need more header fixes, or clean builds.

[David Kilzer (:ddkilzer)]

Created attachment 349626 [details]
Patch v3

Fix path to JSAPIValueWrapper.h in CMakeLists.txt.

[Filip Pizlo]

Rs=me for fixes to the rest of the fallout.

[David Kilzer (:ddkilzer)]

Created attachment 349629 [details]
Patch v4 (for landing if it builds)

Fix path to hasher.py in CMakeLists.txt, and add missing dependency on hasher.py to DerivedSources.make.

[EWS Watchlist]

Comment on attachment 349629 [details]
Patch v4 (for landing if it builds)

Attachment 349629 [details] did not pass jsc-ews (mac):
Output: https://webkit-queues.webkit.org/results/9199964

New failing tests:
stress/ftl-get-by-id-getter-exception-interesting-live-state.js.ftl-eager
apiTests

[EWS Watchlist]

Comment on attachment 349629 [details]
Patch v4 (for landing if it builds)

Attachment 349629 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9201508

New failing tests:
accessibility/smart-invert-reference.html

[EWS Watchlist]

Created attachment 349652 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 349629 [details]
Patch v4 (for landing if it builds)

Attachment 349629 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9201842

New failing tests:
fast/animation/css-animation-resuming-when-visible-with-style-change2.html

[EWS Watchlist]

Created attachment 349658 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[David Kilzer (:ddkilzer)]

Committed r235972: <https://trac.webkit.org/changeset/235972>

[Radar WebKit Bug Importer]

<rdar://problem/44415797>