WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
189566
Additional tests for conic gradients
https://bugs.webkit.org/show_bug.cgi?id=189566
Summary
Additional tests for conic gradients
Megan Gardner
Reported
2018-09-12 15:58:34 PDT
Additional tests for conic gradients
Attachments
Patch
(16.37 KB, patch)
2018-09-12 16:00 PDT
,
Megan Gardner
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2
(3.16 MB, application/zip)
2018-09-12 19:15 PDT
,
EWS Watchlist
no flags
Details
Patch for landing
(16.11 KB, patch)
2018-09-13 16:59 PDT
,
Megan Gardner
no flags
Details
Formatted Diff
Diff
Patch for landing
(16.03 KB, patch)
2018-09-14 15:04 PDT
,
Megan Gardner
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Megan Gardner
Comment 1
2018-09-12 16:00:49 PDT
Created
attachment 349592
[details]
Patch
Simon Fraser (smfr)
Comment 2
2018-09-12 16:47:12 PDT
Comment on
attachment 349592
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=349592&action=review
> LayoutTests/platform/mac/TestExpectations:1773 > +# Mark these as failing while Internal Debug Features default to off in WKTR > +imported/w3c/web-platform-tests/media-source/mediasource-changetype.html [ Pass Failure ] > +imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html [ Pass Failure ]
I don't think you meant to add these.
EWS Watchlist
Comment 3
2018-09-12 19:15:20 PDT
Comment on
attachment 349592
[details]
Patch
Attachment 349592
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
https://webkit-queues.webkit.org/results/9197916
New failing tests: fast/animation/css-animation-resuming-when-visible-with-style-change2.html
EWS Watchlist
Comment 4
2018-09-12 19:15:21 PDT
Created
attachment 349613
[details]
Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Megan Gardner
Comment 5
2018-09-13 16:59:16 PDT
Created
attachment 349716
[details]
Patch for landing
WebKit Commit Bot
Comment 6
2018-09-14 14:44:15 PDT
Comment on
attachment 349716
[details]
Patch for landing Rejecting
attachment 349716
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 349716, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as
commit-queue@webkit.org
... Fetching:
https://bugs.webkit.org/attachment.cgi?id=349716&action=edit
Fetching:
https://bugs.webkit.org/show_bug.cgi?id=189566
&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 349716 from
bug 189566
. Fetching:
https://bugs.webkit.org/attachment.cgi?id=349716
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 10 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/TestExpectations Hunk #1 FAILED at 2245. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/TestExpectations.rej patching file LayoutTests/fast/gradients/conic-gradient-alpha-expected.html patching file LayoutTests/fast/gradients/conic-gradient-alpha.html patching file LayoutTests/fast/gradients/conic-gradient-expected.html patching file LayoutTests/fast/gradients/conic-gradient-extended-stops-expected.html patching file LayoutTests/fast/gradients/conic-gradient-extended-stops.html patching file LayoutTests/fast/gradients/conic-gradient.html patching file LayoutTests/platform/ios-12/TestExpectations Hunk #1 FAILED at 32. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/ios-12/TestExpectations.rej patching file LayoutTests/platform/mac/TestExpectations Hunk #1 FAILED at 1764. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/TestExpectations.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output:
https://webkit-queues.webkit.org/results/9220202
Megan Gardner
Comment 7
2018-09-14 15:04:25 PDT
Created
attachment 349812
[details]
Patch for landing
WebKit Commit Bot
Comment 8
2018-09-14 17:34:06 PDT
Comment on
attachment 349812
[details]
Patch for landing Clearing flags on attachment: 349812 Committed
r236027
: <
https://trac.webkit.org/changeset/236027
>
WebKit Commit Bot
Comment 9
2018-09-14 17:34:08 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10
2018-09-14 17:35:35 PDT
<
rdar://problem/44475306
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug